Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2811283003: AEC3 Tuning changes (Closed)

Created:
3 years, 8 months ago by peah-webrtc
Modified:
3 years, 8 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

AEC3 Tuning changes. This CL adds tuning to AEC3 for the purpose of reducing the impact of gain changes in the analog microphone gain. BUG=chromium:710818, webrtc:6018 Review-Url: https://codereview.webrtc.org/2811283003 Cr-Commit-Position: refs/heads/master@{#17673} Committed: https://chromium.googlesource.com/external/webrtc/+/103ac7e7d9c3548bf43ffa3a24b5e89689695c02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M webrtc/modules/audio_processing/aec3/aec_state.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
peah-webrtc
Hi, Could you please take a look at this CL.
3 years, 8 months ago (2017-04-12 11:20:43 UTC) #4
aleloi
lgtm!
3 years, 8 months ago (2017-04-12 11:42:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2811283003/20001
3 years, 8 months ago (2017-04-12 12:18:44 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 12:41:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/103ac7e7d9c3548bf43ffa3a2...

Powered by Google App Engine
This is Rietveld 408576698