Make InterpolationEnvironment virutal

Make InterpolationEnvironment virutal

This change refactors InterpolationEnvironment to be virtual and splits
its members between two subclasses, one for CSS and one for SVG.
This gives us better separation between the two environments and provides
better type checking to make sure the appropriate data member is being
accessed for the context.

This patch introduces no changes in behaviour.

BUG=671904
Review-Url: https://codereview.chromium.org/2811253003
Cr-Commit-Position: refs/heads/master@{#475288}
Committed: https://chromium.googlesource.com/chromium/src/+/90832f4a196820a9ff74e7464286330bbd255b69

[alancutter (OOO until 2018), 2017-05-25 07:34:11]

Description was changed from

==========
+interpolationEnvironmentVirtual

BUG=
==========

to

==========
+interpolationEnvironmentVirtual

BUG=671904
==========

[alancutter (OOO until 2018), 2017-05-26 01:13:00]

Description was changed from

==========
+interpolationEnvironmentVirtual

BUG=671904
==========

to

==========
Make InterpolationEnvironment virutal

This change refactors InterpolationEnvironment to be virtual and splits
its members between two subclasses, one for CSS and one for SVG.
This gives us better separation between the two environments and provides
better type checking to make sure the appropriate data member is being
accessed for the context.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-05-26 01:13:00]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[alancutter (OOO until 2018), 2017-05-26 01:18:35]

Description was changed from

==========
Make InterpolationEnvironment virutal

This change refactors InterpolationEnvironment to be virtual and splits
its members between two subclasses, one for CSS and one for SVG.
This gives us better separation between the two environments and provides
better type checking to make sure the appropriate data member is being
accessed for the context.

BUG=671904
==========

to

==========
Make InterpolationEnvironment virutal

This change refactors InterpolationEnvironment to be virtual and splits
its members between two subclasses, one for CSS and one for SVG.
This gives us better separation between the two environments and provides
better type checking to make sure the appropriate data member is being
accessed for the context.

This patch introduces no changes in behaviour.

BUG=671904
==========

[Eric Willigers, 2017-05-26 01:34:17]

lgtm with nit

https://codereview.chromium.org/2811253003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/InterpolationEnvironment.h
(right):

https://codereview.chromium.org/2811253003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/InterpolationEnvironment.h:26:
InterpolationEnvironment(const InterpolationTypesMap& map)
explicit

[Eric Willigers, 2017-05-26 01:37:04]

https://codereview.chromium.org/2811253003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/InterpolationEnvironment.h
(right):

https://codereview.chromium.org/2811253003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/InterpolationEnvironment.h:16: virtual
~InterpolationEnvironment() {}
Could be protected.

[alancutter (OOO until 2018), 2017-05-26 01:42:10]

https://codereview.chromium.org/2811253003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/InterpolationEnvironment.h
(right):

https://codereview.chromium.org/2811253003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/InterpolationEnvironment.h:16: virtual
~InterpolationEnvironment() {}
On 2017/05/26 at 01:37:03, Eric Willigers wrote:
> Could be protected.

Done.

https://codereview.chromium.org/2811253003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/InterpolationEnvironment.h:26:
InterpolationEnvironment(const InterpolationTypesMap& map)
On 2017/05/26 at 01:34:17, Eric Willigers wrote:
> explicit

Done.

[alancutter (OOO until 2018), 2017-05-26 04:58:26]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 04:59:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 07:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 07:01:07]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-05-29 03:07:43]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-05-29 03:07:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2811253003/#ps100001
(title: "protected")

[commit-bot: I haz the power, 2017-05-29 03:07:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 04:54:21]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496027263339420,
"parent_rev": "3ecac93803273c7b0fccd67e575f4f5101bfea5b", "commit_rev":
"90832f4a196820a9ff74e7464286330bbd255b69"}

[commit-bot: I haz the power, 2017-05-29 04:54:31]

Description was changed from

==========
Make InterpolationEnvironment virutal

This change refactors InterpolationEnvironment to be virtual and splits
its members between two subclasses, one for CSS and one for SVG.
This gives us better separation between the two environments and provides
better type checking to make sure the appropriate data member is being
accessed for the context.

This patch introduces no changes in behaviour.

BUG=671904
==========

to

==========
Make InterpolationEnvironment virutal

This change refactors InterpolationEnvironment to be virtual and splits
its members between two subclasses, one for CSS and one for SVG.
This gives us better separation between the two environments and provides
better type checking to make sure the appropriate data member is being
accessed for the context.

This patch introduces no changes in behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2811253003
Cr-Commit-Position: refs/heads/master@{#475288}
Committed:
https://chromium.googlesource.com/chromium/src/+/90832f4a196820a9ff74e7464286...
==========

[commit-bot: I haz the power, 2017-05-29 04:54:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/90832f4a196820a9ff74e7464286...