Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2810973002: Restore old (deprecated) signature of initializeAndroidGlobals. (Closed)

Created:
3 years, 8 months ago by Taylor Brandstetter
Modified:
3 years, 8 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restore old (deprecated) signature of initializeAndroidGlobals. This CL removed a couple parameters from the method, and changed the type of the first parameter to an android.content.Context: https://codereview.webrtc.org/2800353002/ But applications still using the old method may have already upcast the context parameter to an Object, in which case this is a breaking change. So, leaving the old signature exactly as it was before, for maximum backwards compatibility. BUG=webrtc:3416 TBR=magjed@webrtc.org Review-Url: https://codereview.webrtc.org/2810973002 Cr-Commit-Position: refs/heads/master@{#17630} Committed: https://chromium.googlesource.com/external/webrtc/+/8c459f9eeeb5c9dd49edc184c313bdb90d14c133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2810973002/1
3 years, 8 months ago (2017-04-10 23:41:18 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 01:07:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8c459f9eeeb5c9dd49edc184c...

Powered by Google App Engine
This is Rietveld 408576698