Test CreatePeerConnectionFactory() with a forwarding mock AudioDecoderFactory

Test CreatePeerConnectionFactory() with a forwarding mock AudioDecoderFactory

BUG=webrtc:5805
Review-Url: https://codereview.webrtc.org/2810703002
Cr-Commit-Position: refs/heads/master@{#17761}
Committed: https://chromium.googlesource.com/external/webrtc/+/9e5b11ea75bae6c410d332d35933103fe454c2e0

[kwiberg-webrtc, 2017-04-10 12:57:25]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 12:57:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-04-10 12:59:14]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-10 13:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:03:53]

Dry run: Try jobs failed on following builders:
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[kwiberg-webrtc, 2017-04-10 13:06:44]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:06:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 13:46:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:46:55]

Dry run: Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/25173)

[kwiberg-webrtc, 2017-04-11 12:05:11]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[kwiberg-webrtc, 2017-04-11 12:05:11]

I think it's safe to review this now, despite the remaining bot errors.

[kwiberg-webrtc, 2017-04-18 09:41:54]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 09:42:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-04-18 10:09:47]

kwiberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[kwiberg-webrtc, 2017-04-18 10:09:48]

Adding a reviewer who isn't OOO.

[commit-bot: I haz the power, 2017-04-18 10:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 10:10:41]

Dry run: This issue passed the CQ dry run.

[the sun, 2017-04-18 10:38:21]

lgtm % comment

https://codereview.webrtc.org/2810703002/diff/80001/webrtc/pc/peerconnectione...
File webrtc/pc/peerconnectionendtoend_unittest.cc (right):

https://codereview.webrtc.org/2810703002/diff/80001/webrtc/pc/peerconnectione...
webrtc/pc/peerconnectionendtoend_unittest.cc:268:
CreateForwardingMockDecoderFactory(real_decoder_factory.get()));
What's the rationale for only using the mocks here? Would it be better to add a
separate test case?

[kwiberg-webrtc, 2017-04-18 10:56:08]

https://codereview.webrtc.org/2810703002/diff/80001/webrtc/pc/peerconnectione...
File webrtc/pc/peerconnectionendtoend_unittest.cc (right):

https://codereview.webrtc.org/2810703002/diff/80001/webrtc/pc/peerconnectione...
webrtc/pc/peerconnectionendtoend_unittest.cc:268:
CreateForwardingMockDecoderFactory(real_decoder_factory.get()));
On 2017/04/18 10:38:21, the sun wrote:
> What's the rationale for only using the mocks here?

IIRC only the two Call* tests actually decode audio packets. If I were to
support the others as well, I would need to EXPECT different things there. I
went with the simplest possible solution.

> Would it be better to add a separate test case?

I didn't do that because this one already does what I want, and injecting a
forwarding mock doesn't change at all what the test does, so duplicating it
seemed unnecessary.

[kwiberg-webrtc, 2017-04-19 10:32:17]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-04-19 10:32:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-19 10:47:58]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492597937280550,
"parent_rev": "75c08eaffc7ca2ef9ae487db132ca211becb9ee3", "commit_rev":
"9e5b11ea75bae6c410d332d35933103fe454c2e0"}

[commit-bot: I haz the power, 2017-04-19 10:48:02]

Description was changed from

==========
Test CreatePeerConnectionFactory() with a forwarding mock AudioDecoderFactory

BUG=webrtc:5805
==========

to

==========
Test CreatePeerConnectionFactory() with a forwarding mock AudioDecoderFactory

BUG=webrtc:5805

Review-Url: https://codereview.webrtc.org/2810703002
Cr-Commit-Position: refs/heads/master@{#17761}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9e5b11ea75bae6c410d332d35...
==========

[commit-bot: I haz the power, 2017-04-19 10:48:03]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/9e5b11ea75bae6c410d332d35...