Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2810533003: Removed workaround for the WARN_UNUSED_RESULT issue. (Closed)

Created:
3 years, 8 months ago by peah-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed workaround for the WARN_UNUSED_RESULT issue. BUG=webrtc:6018 Review-Url: https://codereview.webrtc.org/2810533003 Cr-Commit-Position: refs/heads/master@{#17615} Committed: https://chromium.googlesource.com/external/webrtc/+/925e9d762c107230fe96eb0e8c2bb4dab87417fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M webrtc/modules/audio_processing/aec3/echo_canceller3.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
peah-webrtc
Hi, Could you please take a look at this small CL. Best, Per
3 years, 8 months ago (2017-04-10 08:20:57 UTC) #2
ivoc
LGTM.
3 years, 8 months ago (2017-04-10 09:40:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2810533003/1
3 years, 8 months ago (2017-04-10 10:09:39 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 11:18:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/925e9d762c107230fe96eb0e8...

Powered by Google App Engine
This is Rietveld 408576698