Further SSE2 optimizations for the AEC3 adaptive filter.

Further SSE2 optimizations for the AEC3 adaptive filter.

This CL adds further SSE2 optimizations for the AEC3 
adaptive filter.

The changes are bitexact

BUG=webrtc:6018
Review-Url: https://codereview.webrtc.org/2810133002
Cr-Commit-Position: refs/heads/master@{#17667}
Committed: https://chromium.googlesource.com/external/webrtc/+/69ffdf49382cda8ae4baa7173ab5237cb815292a

[peah-webrtc, 2017-04-12 05:46:44]

Description was changed from

==========
More opt

BUG=
==========

to

==========
Further SSE2 optimizations for the AEC3 adaptive filter.

This CL adds further SSE2 optimizations for the AEC3 
adaptive filter.

The changes are bitexact

BUG=webrtc:6018
==========

[peah-webrtc, 2017-04-12 05:47:04]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2017-04-12 05:47:10]

Patchset #1 (id:20001) has been deleted

[peah-webrtc, 2017-04-12 05:48:32]

peah@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[peah-webrtc, 2017-04-12 05:48:33]

ivoc@: This is one further CL for SSE2 optimizations. Could you PTAL.

[peah-webrtc, 2017-04-12 05:48:38]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 05:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-12 06:03:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 06:03:53]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)

[ivoc, 2017-04-12 09:22:23]

LGTM, just a few small comments.

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc (left):

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc:50: // Computes and
stores the echo return loss estimate of the filter, which is the
I think it would be good to keep the comment.

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc (right):

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc:56:
std::vector<std::array<float, kFftLengthBy2Plus1>>* H2) {
Please add a DCHECK to verify that the size of H and the size of H2 is equal.

[peah-webrtc, 2017-04-12 09:44:27]

Thanks for the comments! I uploaded a patch according to those.

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc (left):

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc:50: // Computes and
stores the echo return loss estimate of the filter, which is the
On 2017/04/12 09:22:22, ivoc wrote:
> I think it would be good to keep the comment.

Done.

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc (right):

https://codereview.webrtc.org/2810133002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc:56:
std::vector<std::array<float, kFftLengthBy2Plus1>>* H2) {
On 2017/04/12 09:22:22, ivoc wrote:
> Please add a DCHECK to verify that the size of H and the size of H2 is equal.

Done.

[peah-webrtc, 2017-04-12 09:44:31]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2017-04-12 09:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2810133002/#ps70004 (title:
"Added comments")

[commit-bot: I haz the power, 2017-04-12 09:44:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-12 10:04:09]

CQ is committing da patch.

Bot data: {"patchset_id": 70004, "attempt_start_ts": 1491990271421090,
"parent_rev": "1c223b2f7557ff449add7a114d72ea97614731b5", "commit_rev":
"69ffdf49382cda8ae4baa7173ab5237cb815292a"}

[commit-bot: I haz the power, 2017-04-12 10:04:13]

Description was changed from

==========
Further SSE2 optimizations for the AEC3 adaptive filter.

This CL adds further SSE2 optimizations for the AEC3 
adaptive filter.

The changes are bitexact

BUG=webrtc:6018
==========

to

==========
Further SSE2 optimizations for the AEC3 adaptive filter.

This CL adds further SSE2 optimizations for the AEC3 
adaptive filter.

The changes are bitexact

BUG=webrtc:6018

Review-Url: https://codereview.webrtc.org/2810133002
Cr-Commit-Position: refs/heads/master@{#17667}
Committed:
https://chromium.googlesource.com/external/webrtc/+/69ffdf49382cda8ae4baa7173...
==========

[commit-bot: I haz the power, 2017-04-12 10:04:17]

Committed patchset #3 (id:70004) as
https://chromium.googlesource.com/external/webrtc/+/69ffdf49382cda8ae4baa7173...