Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2809613002: Revert of Implemented the GetSources() in native code. (Closed)

Created:
3 years, 8 months ago by olka_webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Implemented the GetSources() in native code. (patchset #11 id:510001 of https://codereview.webrtc.org/2770233003/ ) Reason for revert: Suspected of WebRtcApprtcBrowserTest.MANUAL_WorksOnApprtc breakage, see https://bugs.chromium.org/p/webrtc/issues/detail?id=7465 Original issue's description: > Added the GetSources() to the RtpReceiverInterface and implemented > it for the AudioRtpReceiver. > > This method returns a vector of RtpSource(both CSRC source and SSRC > source) which contains the ID of a source, the timestamp, the source > type (SSRC or CSRC) and the audio level. > > The RtpSource objects are buffered and maintained by the > RtpReceiver in webrtc/modules/rtp_rtcp/. When the method is called, > the info of the contributing source will be pulled along the object > chain: > AudioRtpReceiver -> VoiceChannel -> WebRtcVoiceMediaChannel -> > AudioReceiveStream -> voe::Channel -> RtpRtcp module > > Spec:https://w3c.github.io/webrtc-pc/archives/20151006/webrtc.html#widl-RTCRtpReceiver-getContributingSources-sequence-RTCRtpContributingSource > > BUG=chromium:703122 > TBR=stefan@webrtc.org, danilchap@webrtc.org > > Review-Url: https://codereview.webrtc.org/2770233003 > Cr-Commit-Position: refs/heads/master@{#17591} > Committed: https://chromium.googlesource.com/external/webrtc/+/292084c3765d9f3ee406ca2ec86eae206b540053 TBR=deadbeef@webrtc.org,solenberg@webrtc.org,hbos@webrtc.org,philipel@webrtc.org,stefan@webrtc.org,danilchap@webrtc.org,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:703122 Review-Url: https://codereview.webrtc.org/2809613002 Cr-Commit-Position: refs/heads/master@{#17616} Committed: https://chromium.googlesource.com/external/webrtc/+/fbcc5cb3869d1370008e40f24fc03ac8fb69c675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -563 lines) Patch
M webrtc/api/rtpreceiverinterface.h View 4 chunks +1 line, -45 lines 0 comments Download
M webrtc/api/test/mock_rtpreceiver.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/audio/audio_receive_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/call/audio_receive_stream.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_receiver.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 4 chunks +0 lines, -22 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 6 chunks +5 lines, -101 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/rtp_receiver_unittest.cc View 1 chunk +0 lines, -260 lines 0 comments Download
M webrtc/pc/channel.h View 3 chunks +1 line, -3 lines 0 comments Download
M webrtc/pc/channel.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/pc/peerconnection_integrationtest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/pc/rtpreceiver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/pc/rtpreceiver.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 18 chunks +35 lines, -44 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 3 chunks +1 line, -5 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
olka_webrtc
Created Revert of Implemented the GetSources() in native code.
3 years, 8 months ago (2017-04-10 10:18:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2809613002/1
3 years, 8 months ago (2017-04-10 10:18:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/fbcc5cb3869d1370008e40f24fc03ac8fb69c675
3 years, 8 months ago (2017-04-10 11:38:22 UTC) #6
hbos
3 years, 8 months ago (2017-04-10 14:38:50 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2810623003/ by hbos@webrtc.org.

The reason for reverting is: Re-land, reverting did not fix bug.

https://bugs.chromium.org/p/webrtc/issues/detail?id=7465.

Powered by Google App Engine
This is Rietveld 408576698