Ignore some UBSan errors

Ignore some UBSan errors

They proved to be too difficult to fix properly, so we revert the
saturation fixes that were done in
https://codereview.webrtc.org/2729573002 and
https://codereview.webrtc.org/2746903002, and ignore them instead.

BUG=webrtc:7307, chromium:709364, chromium:693868
Review-Url: https://codereview.webrtc.org/2809483002
Cr-Commit-Position: refs/heads/master@{#17612}
Committed: https://chromium.googlesource.com/external/webrtc/+/49cad02cf38dc54f8ba0bdab28c3dbd21f1d4e81

[kwiberg-webrtc, 2017-04-08 00:25:04]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 00:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-08 00:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 00:46:56]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-04-08 02:16:22]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2017-04-10 07:44:30]

LGTM with a question.

https://codereview.webrtc.org/2809483002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c
(right):

https://codereview.webrtc.org/2809483002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c:516: gainQ10
= WebRtcSpl_DivW32W16ResW16(30 << 10,
This seems just like an exact revert to the old behavior. Was that fix not
necessary?

https://codereview.webrtc.org/2809483002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c:528: gainQ10
= WebRtcSpl_DivW32W16ResW16(36 << 10,
Same question as above.

[kwiberg-webrtc, 2017-04-10 08:13:29]

https://codereview.webrtc.org/2809483002/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c
(right):

https://codereview.webrtc.org/2809483002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c:516: gainQ10
= WebRtcSpl_DivW32W16ResW16(30 << 10,
On 2017/04/10 07:44:30, hlundin-webrtc wrote:
> This seems just like an exact revert to the old behavior. Was that fix not
> necessary?

No---without the change higher up in this file, this change wasn't necessary
either.

https://codereview.webrtc.org/2809483002/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c:528: gainQ10
= WebRtcSpl_DivW32W16ResW16(36 << 10,
On 2017/04/10 07:44:30, hlundin-webrtc wrote:
> Same question as above.

Same answer.

[kwiberg-webrtc, 2017-04-10 08:13:50]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-04-10 08:14:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-10 09:29:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491812030516880, "parent_rev":
"9f2c18e237593b5f8cbc7d7a3838ab6596123c53", "commit_rev":
"49cad02cf38dc54f8ba0bdab28c3dbd21f1d4e81"}

[commit-bot: I haz the power, 2017-04-10 09:29:35]

Description was changed from

==========
Ignore some UBSan errors

They proved to be too difficult to fix properly, so we revert the
saturation fixes that were done in
https://codereview.webrtc.org/2729573002 and
https://codereview.webrtc.org/2746903002, and ignore them instead.

BUG=webrtc:7307, chromium:709364, chromium:693868
==========

to

==========
Ignore some UBSan errors

They proved to be too difficult to fix properly, so we revert the
saturation fixes that were done in
https://codereview.webrtc.org/2729573002 and
https://codereview.webrtc.org/2746903002, and ignore them instead.

BUG=webrtc:7307, chromium:709364, chromium:693868

Review-Url: https://codereview.webrtc.org/2809483002
Cr-Commit-Position: refs/heads/master@{#17612}
Committed:
https://chromium.googlesource.com/external/webrtc/+/49cad02cf38dc54f8ba0bdab2...
==========

[commit-bot: I haz the power, 2017-04-10 09:29:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/49cad02cf38dc54f8ba0bdab2...