Add "ice-option:trickle" to generated offers/answers.

Add "ice-option:trickle" to generated offers/answers.

BUG=webrtc:7443
Review-Url: https://codereview.webrtc.org/2808913003
Cr-Commit-Position: refs/heads/master@{#17809}
Committed: https://chromium.googlesource.com/external/webrtc/+/30952b460ff6e6e0fada8015c362064fac7ba8af

[Taylor Brandstetter, 2017-04-10 19:44:08]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-04-10 19:44:09]

PTAL

[Taylor Brandstetter, 2017-04-20 07:24:31]

Ping

[pthatcher1, 2017-04-21 01:09:55]

lgtm

The comments are just nice to haves later.

https://codereview.webrtc.org/2808913003/diff/1/webrtc/p2p/base/transportdesc...
File webrtc/p2p/base/transportdescription.h (right):

https://codereview.webrtc.org/2808913003/diff/1/webrtc/p2p/base/transportdesc...
webrtc/p2p/base/transportdescription.h:168: // TODO(deadbeef): Rename to
ice_options?
I'd say yes, rename to ice_options.

https://codereview.webrtc.org/2808913003/diff/1/webrtc/p2p/base/transportdesc...
File webrtc/p2p/base/transportdescriptionfactory.cc (right):

https://codereview.webrtc.org/2808913003/diff/1/webrtc/p2p/base/transportdesc...
webrtc/p2p/base/transportdescriptionfactory.cc:40:
desc->AddOption(ICE_OPTION_TRICKLE);
And rename AddOption to AddIceOption

[Taylor Brandstetter, 2017-04-21 09:15:43]

Added TODO for renaming.

[Taylor Brandstetter, 2017-04-21 09:15:49]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-04-21 09:15:49]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2808913003/#ps40001 (title:
"Merge with master")

[commit-bot: I haz the power, 2017-04-21 09:15:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-21 09:41:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492766149393200,
"parent_rev": "d0de295119a32fc994b18e49e1629d88a9d4e386", "commit_rev":
"30952b460ff6e6e0fada8015c362064fac7ba8af"}

[commit-bot: I haz the power, 2017-04-21 09:41:33]

Description was changed from

==========
Add "ice-option:trickle" to generated offers/answers.

BUG=webrtc:7443
==========

to

==========
Add "ice-option:trickle" to generated offers/answers.

BUG=webrtc:7443

Review-Url: https://codereview.webrtc.org/2808913003
Cr-Commit-Position: refs/heads/master@{#17809}
Committed:
https://chromium.googlesource.com/external/webrtc/+/30952b460ff6e6e0fada8015c...
==========

[commit-bot: I haz the power, 2017-04-21 09:41:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/30952b460ff6e6e0fada8015c...