Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2808833002: Delay based logging. (Closed)

Created:
3 years, 8 months ago by philipel
Modified:
3 years, 8 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delay based logging. BUG=none Review-Url: https://codereview.webrtc.org/2808833002 Cr-Commit-Position: refs/heads/master@{#17641} Committed: https://chromium.googlesource.com/external/webrtc/+/10fc0e6385b812981f6b64f611259887ca14de51

Patch Set 1 #

Total comments: 3

Patch Set 2 : Unittest fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 2 chunks +7 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M webrtc/tools/event_log_visualizer/plot_python.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
philipel
https://codereview.webrtc.org/2808833002/diff/1/webrtc/tools/event_log_visualizer/plot_python.cc File webrtc/tools/event_log_visualizer/plot_python.cc (right): https://codereview.webrtc.org/2808833002/diff/1/webrtc/tools/event_log_visualizer/plot_python.cc#newcode81 webrtc/tools/event_log_visualizer/plot_python.cc:81: "marker='o', ls=' ')\n", The '.' format is really hard ...
3 years, 8 months ago (2017-04-10 13:20:45 UTC) #2
terelius
lgtm https://codereview.webrtc.org/2808833002/diff/1/webrtc/tools/event_log_visualizer/plot_python.cc File webrtc/tools/event_log_visualizer/plot_python.cc (right): https://codereview.webrtc.org/2808833002/diff/1/webrtc/tools/event_log_visualizer/plot_python.cc#newcode81 webrtc/tools/event_log_visualizer/plot_python.cc:81: "marker='o', ls=' ')\n", On 2017/04/10 13:20:44, philipel wrote: ...
3 years, 8 months ago (2017-04-10 13:46:27 UTC) #7
philipel
https://codereview.webrtc.org/2808833002/diff/1/webrtc/tools/event_log_visualizer/plot_python.cc File webrtc/tools/event_log_visualizer/plot_python.cc (right): https://codereview.webrtc.org/2808833002/diff/1/webrtc/tools/event_log_visualizer/plot_python.cc#newcode81 webrtc/tools/event_log_visualizer/plot_python.cc:81: "marker='o', ls=' ')\n", On 2017/04/10 13:46:27, terelius wrote: > ...
3 years, 8 months ago (2017-04-10 13:55:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808833002/1
3 years, 8 months ago (2017-04-10 15:13:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/23787)
3 years, 8 months ago (2017-04-10 15:21:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808833002/20001
3 years, 8 months ago (2017-04-11 08:47:52 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 08:50:28 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/10fc0e6385b812981f6b64f61...

Powered by Google App Engine
This is Rietveld 408576698