Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2808343002: Rename COMPILE_ASSERT macro to RTC_COMPILE_ASSERT (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, kwiberg-webrtc, Andrew MacDonald, zhengzhonghou_agora.io, fengyue_agora.io, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, mflodman, peah-webrtc, minyue-webrtc, henrika_webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename COMPILE_ASSERT macro to RTC_COMPILE_ASSERT This is needed to avoid name collision with some downstream projects. BUG=b/37224347 TBR=henrika@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2808343002 Cr-Commit-Position: refs/heads/master@{#17634} Committed: https://chromium.googlesource.com/external/webrtc/+/e0ab0ad85d5e8a6a83584c8d24762c5508294448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M webrtc/common_audio/signal_processing/include/spl_inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_c.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_estimator_mips.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/pitch_filter.c View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/source/pitch_filter.c View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/include/compile_assert_c.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
kwiberg-webrtc
lgtm! We should probably go through all our macros at some point and prefix them ...
3 years, 8 months ago (2017-04-11 06:14:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808343002/1
3 years, 8 months ago (2017-04-11 06:18:52 UTC) #7
kjellander_webrtc
TBR'ing henrika@ since I need to get this in to unbreak things.
3 years, 8 months ago (2017-04-11 06:19:08 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 06:21:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e0ab0ad85d5e8a6a83584c8d2...

Powered by Google App Engine
This is Rietveld 408576698