Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 2808273002: Add error codes for Android audio recording start errors. (Closed)

Created:
3 years, 8 months ago by AlexG
Modified:
3 years, 8 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add error codes for Android audio recording start errors. BUG=b/36090624 Review-Url: https://codereview.webrtc.org/2808273002 Cr-Commit-Position: refs/heads/master@{#17747} Committed: https://chromium.googlesource.com/external/webrtc/+/07cd1ba0234e2370f6311d615ad4074144dd1645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
AlexG
3 years, 8 months ago (2017-04-11 00:02:31 UTC) #2
henrika_webrtc
lgtm
3 years, 8 months ago (2017-04-18 11:43:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808273002/1
3 years, 8 months ago (2017-04-18 17:06:58 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 17:30:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/07cd1ba0234e2370f6311d615...

Powered by Google App Engine
This is Rietveld 408576698