Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2808073002: Add information about microphone gain changes to AEC3 (Closed)

Created:
3 years, 8 months ago by peah-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ivoc, aleloi
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add information about microphone gain changes to AEC3 Changes in the microphone gain are effecting the AEC in the sense that each change in the microphone gain is a change in the echo path seen by the AEC. This CL utilizes the ability of AEC3 to leverage information about known changes in the analog microphone gain. BUG=webrtc:6018 Review-Url: https://codereview.webrtc.org/2808073002 Cr-Commit-Position: refs/heads/master@{#17625} Committed: https://chromium.googlesource.com/external/webrtc/+/6799553a2cbe2470115a7db01ed14f4a4c593d88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
peah-webrtc
Hi, This is a very short CL that hooks up the analog AGC functionality with ...
3 years, 8 months ago (2017-04-10 13:17:49 UTC) #3
ivoc
lgtm.
3 years, 8 months ago (2017-04-10 13:44:43 UTC) #4
aleloi
lgtm
3 years, 8 months ago (2017-04-10 13:47:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808073002/1
3 years, 8 months ago (2017-04-10 13:57:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/23782)
3 years, 8 months ago (2017-04-10 14:06:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808073002/1
3 years, 8 months ago (2017-04-10 20:50:02 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 21:12:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6799553a2cbe2470115a7db01...

Powered by Google App Engine
This is Rietveld 408576698