Move RtpTransportControllerSend to a new file.

Move RtpTransportControllerSend to a new file.

Also move RtpTransportControllerSendInterface to its own header file.

BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2808043002
Cr-Commit-Position: refs/heads/master@{#17840}
Committed: https://chromium.googlesource.com/external/webrtc/+/cae45d0469ce03bcabdfd59297f834744741a261

[nisse-webrtc, 2017-04-10 09:46:46]

nisse@webrtc.org changed reviewers:
+ solenberg@webrtc.org, stefan@webrtc.org

[the sun, 2017-04-18 10:05:36]

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
File webrtc/call/rtp_transport_controller_send.cc (right):

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send.cc:23: // Must be called only once.
DCHECK that instead, possibly in the SendSideCC (not clear to me whether the
constraint is on RtpTransportControllerSend or SendSideCongestionController).

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
File webrtc/call/rtp_transport_controller_send.h (right):

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send.h:25: class RtpTransportControllerSend
: public RtpTransportControllerSendInterface {
final

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send.h:44: SendSideCongestionController
send_side_cc_;
DISALLOW_COPY_AND_ASSIGN()

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
File webrtc/call/rtp_transport_controller_send_interface.h (right):

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send_interface.h:16: class Module;
Remove unneeded forward decls Module and VieRemb.

[nisse-webrtc, 2017-04-18 11:48:30]

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
File webrtc/call/rtp_transport_controller_send.cc (right):

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send.cc:23: // Must be called only once.
On 2017/04/18 10:05:35, the sun wrote:
> DCHECK that instead, possibly in the SendSideCC (not clear to me whether the
> constraint is on RtpTransportControllerSend or SendSideCongestionController).

There already is a DCHECK in the SendSideCC method. Do you want me to delete
this comment?

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
File webrtc/call/rtp_transport_controller_send.h (right):

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send.h:25: class RtpTransportControllerSend
: public RtpTransportControllerSendInterface {
On 2017/04/18 10:05:35, the sun wrote:
> final

Can you explain what to do, and why? I'm not used to "final" in C++.

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send.h:44: SendSideCongestionController
send_side_cc_;
On 2017/04/18 10:05:35, the sun wrote:
> DISALLOW_COPY_AND_ASSIGN()

Done.

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
File webrtc/call/rtp_transport_controller_send_interface.h (right):

https://codereview.webrtc.org/2808043002/diff/1/webrtc/call/rtp_transport_con...
webrtc/call/rtp_transport_controller_send_interface.h:16: class Module;
On 2017/04/18 10:05:36, the sun wrote:
> Remove unneeded forward decls Module and VieRemb.

Done.

[nisse-webrtc, 2017-04-24 10:54:45]

Ping?

[the sun, 2017-04-24 11:59:12]

lgtm

[stefan-webrtc, 2017-04-24 12:04:12]

lgtm

[nisse-webrtc, 2017-04-24 12:07:48]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 12:07:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-24 12:29:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 12:29:53]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-04-24 12:50:58]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-04-24 12:51:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-24 12:53:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493038258320650,
"parent_rev": "a244ec659d7973e78952065b332511d5533ca9e0", "commit_rev":
"cae45d0469ce03bcabdfd59297f834744741a261"}

[commit-bot: I haz the power, 2017-04-24 12:53:24]

Description was changed from

==========
Move RtpTransportControllerSend to a new file.

Also move RtpTransportControllerSendInterface to its own header file.

BUG=webrtc:7135
==========

to

==========
Move RtpTransportControllerSend to a new file.

Also move RtpTransportControllerSendInterface to its own header file.

BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/2808043002
Cr-Commit-Position: refs/heads/master@{#17840}
Committed:
https://chromium.googlesource.com/external/webrtc/+/cae45d0469ce03bcabdfd5929...
==========

[commit-bot: I haz the power, 2017-04-24 12:53:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/cae45d0469ce03bcabdfd5929...