Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2807133002: Do not report cpu limited resolution stats when degradation preference is disabled and no scaling i… (Closed)

Created:
3 years, 8 months ago by åsapersson
Modified:
3 years, 8 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not report cpu limited resolution stats when degradation preference is disabled and no scaling is done. When degradation preference is kDegradationDisabled, do not update WebRTC.Video.CpuLimitedResolutionInPercent. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2807133002 Cr-Commit-Position: refs/heads/master@{#17757} Committed: https://chromium.googlesource.com/external/webrtc/+/f4e44af724b28eaef7d6806617e5d55b9bb135ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M webrtc/video/send_statistics_proxy.cc View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 chunk +16 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
åsapersson
3 years, 8 months ago (2017-04-18 13:52:07 UTC) #4
brandtr
lgtm
3 years, 8 months ago (2017-04-19 07:27:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2807133002/20001
3 years, 8 months ago (2017-04-19 08:40:14 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 09:01:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f4e44af724b28eaef7d680661...

Powered by Google App Engine
This is Rietveld 408576698