Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2806933002:
Fix invalid output buffer usage (Closed)
|
Created:
3 years, 8 months ago by Steweg Modified:
3 years, 8 months ago CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, yujie_mao (webrtc) Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix invalid output buffer usage
This patch fixes the internal AudioCoder output buffer setting to be set
prior it will be used within callback from ACM
BUG=webrtc:7462
Review-Url: https://codereview.webrtc.org/2806933002
Cr-Commit-Position: refs/heads/master@{#17800}
Committed: https://chromium.googlesource.com/external/webrtc/+/a1fa491334a629ed479c24472ac1b060bbc55531
Patch Set 1 #
Total comments: 2
Patch Set 2 : Moving myself within AUTHOR file #Patch Set 3 : Rebased to master and correct the order of AUTHORs #Messages
Total messages: 39 (30 generated)
The CQ bit was checked by steweg@gmail.com
The CQ bit was unchecked by steweg@gmail.com
Description was changed from ========== Fix invalid output buffer usage This patch fixes the internal AudioCoder output buffer setting to be set prior it will be used within callback from ACM BUG= ========== to ========== Fix invalid output buffer usage This patch fixes the internal AudioCoder output buffer setting to be set prior it will be used within callback from ACM BUG= ==========
steweg@gmail.com changed reviewers: + henrika@webrtc.org
steweg@gmail.com changed required reviewers: + henrika@webrtc.org
The CQ bit was checked by steweg@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by steweg@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Fix invalid output buffer usage This patch fixes the internal AudioCoder output buffer setting to be set prior it will be used within callback from ACM BUG= ========== to ========== Fix invalid output buffer usage This patch fixes the internal AudioCoder output buffer setting to be set prior it will be used within callback from ACM BUG=webrtc:7462 ==========
The CQ bit was checked by ossu@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
henrika@webrtc.org changed reviewers: + henrik.lundin@webrtc.org - henrika@webrtc.org
henrika@webrtc.org changed required reviewers: - henrika@webrtc.org
The CQ bit was checked by steweg@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
steweg@gmail.com changed reviewers: + kwiberg@webrtc.org
steweg@gmail.com changed required reviewers: + kwiberg@webrtc.org
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
lgtm. Thanks! But please shelve yourself in alphabetical order. https://codereview.webrtc.org/2806933002/diff/1/AUTHORS File AUTHORS (right): https://codereview.webrtc.org/2806933002/diff/1/AUTHORS#newcode49 AUTHORS:49: Stefan Gula <steweg@gmail.com> Please try to preserve the alphabetical order.
https://codereview.webrtc.org/2806933002/diff/1/AUTHORS File AUTHORS (right): https://codereview.webrtc.org/2806933002/diff/1/AUTHORS#newcode49 AUTHORS:49: Stefan Gula <steweg@gmail.com> On 2017/04/20 19:53:46, kwiberg-webrtc wrote: > Please try to preserve the alphabetical order. Done.
The CQ bit was checked by kwiberg@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org Link to the patchset: https://codereview.webrtc.org/2806933002/#ps40001 (title: "Rebased to master and correct the order of AUTHORs")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492724479512890,
"parent_rev": "d41af462fb11a4854e25a84bb0d27b8c3fdd5519", "commit_rev":
"a1fa491334a629ed479c24472ac1b060bbc55531"}
Message was sent while issue was closed.
Description was changed from ========== Fix invalid output buffer usage This patch fixes the internal AudioCoder output buffer setting to be set prior it will be used within callback from ACM BUG=webrtc:7462 ========== to ========== Fix invalid output buffer usage This patch fixes the internal AudioCoder output buffer setting to be set prior it will be used within callback from ACM BUG=webrtc:7462 Review-Url: https://codereview.webrtc.org/2806933002 Cr-Commit-Position: refs/heads/master@{#17800} Committed: https://chromium.googlesource.com/external/webrtc/+/a1fa491334a629ed479c24472... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/a1fa491334a629ed479c24472... |
