Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Issue 2806693004: Fix compilation issues of std::unique_ptr (Closed)

Created:
3 years, 8 months ago by Steweg
Modified:
3 years, 8 months ago
Reviewers:
*tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix compilation issues of std::unique_ptr This patch fixes compilation issues related to usage of std::unique_ptr and NULL instead of nullptr. This issue pops up once you would try to compile whole webrtc with using C++14 and gcc-4.9 BUG=webrtc:7461 Review-Url: https://codereview.webrtc.org/2806693004 Cr-Commit-Position: refs/heads/master@{#17600} Committed: https://chromium.googlesource.com/external/webrtc/+/4b37127414225ef6a85b910643d76e3dbb739e12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/transportdescription.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/videocapturertracksource.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
Steweg
3 years, 8 months ago (2017-04-08 09:03:43 UTC) #4
tommi
lgtm
3 years, 8 months ago (2017-04-09 15:03:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2806693004/1
3 years, 8 months ago (2017-04-09 15:03:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15942)
3 years, 8 months ago (2017-04-09 15:08:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2806693004/1
3 years, 8 months ago (2017-04-09 16:03:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2806693004/1
3 years, 8 months ago (2017-04-09 16:05:55 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-09 16:09:15 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4b37127414225ef6a85b91064...

Powered by Google App Engine
This is Rietveld 408576698