Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2806463003: Make PacketTransportInternal inherit from PacketTransportInterface. (Closed)

Created:
3 years, 8 months ago by Taylor Brandstetter
Modified:
3 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make PacketTransportInternal inherit from PacketTransportInterface. Was just overlooked in an earlier CL. BUG=webrtc:7013 TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2806463003 Cr-Commit-Position: refs/heads/master@{#17579} Committed: https://chromium.googlesource.com/external/webrtc/+/225bfc0971e2986bd42af5c0a6f5c70fa07b6dd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M webrtc/api/ortc/udptransportinterface.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/fakepackettransport.h View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/p2p/base/packettransportinternal.h View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Taylor Brandstetter
PTAL; I just did this to see if it would work, but since it does, ...
3 years, 8 months ago (2017-04-07 04:44:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2806463003/1
3 years, 8 months ago (2017-04-07 04:45:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/225bfc0971e2986bd42af5c0a6f5c70fa07b6dd3
3 years, 8 months ago (2017-04-07 04:47:37 UTC) #13
pthatcher1
3 years, 8 months ago (2017-04-07 21:26:27 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698