Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

When SSRCs aren't signaled, an SSRC of 0 is used internally to mean
"the default receive stream". But this wasn't working with the
implementation of GetRtpReceiveParameters in the audio/video
engines. This was breaking RtpReceiver.GetParameters in this situation,
as well as the new getStats implementation (which relies on
GetParameters).

The new implementation will fail if *no* default receive stream is
configured (meaning no default sink is set), and otherwise will return
a default RtpEncodingParameters (later it will be filled with relevant
SDP parameters as they're implemented).

BUG=webrtc:6971
Review-Url: https://codereview.webrtc.org/2806173002
Cr-Commit-Position: refs/heads/master@{#17803}
Committed: https://chromium.googlesource.com/external/webrtc/+/3bc15103aea1dd2fdfc01b833b62f34171c82e81

[Taylor Brandstetter, 2017-04-10 04:05:24]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-04-10 04:06:30]

Description was changed from

==========
Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

When SSRCs aren't signaled, an SSRC of 0 is used to mean "the default
receive stream". But this wasn't working with the implementation of
GetRtpReceiveParameters in the audio/video engines. This breaks
RtpReceiver.GetParameters in this situation, as well as the new getStats
implementation (which relies on GetParameters).

The new implementation will fail if *no* default receive stream is
configured (meaning no default sink is set), and otherwise will return
a default RtpEncodingParameters, with the SSRC populated if known.

BUG=webrtc:6971
==========

to

==========
Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

When SSRCs aren't signaled, an SSRC of 0 is used internally to mean
"the default receive stream". But this wasn't working with the
implementation of GetRtpReceiveParameters in the audio/video
engines. This was breaking RtpReceiver.GetParameters in this situation,
as well as the new getStats implementation (which relies on
GetParameters).

The new implementation will fail if *no* default receive stream is
configured (meaning no default sink is set), and otherwise will return
a default RtpEncodingParameters, with the SSRC populated if known.

BUG=webrtc:6971
==========

[the sun, 2017-04-18 18:27:20]

https://codereview.webrtc.org/2806173002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2806173002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:1761: if (!default_sink_) {
Checking !unsignaled_recv_ssrcs_.empty() should be enough, if I'm not mistaken.

[Taylor Brandstetter, 2017-04-20 07:16:22]

Pinging Peter.

https://codereview.webrtc.org/2806173002/diff/1/webrtc/media/engine/webrtcvoi...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/2806173002/diff/1/webrtc/media/engine/webrtcvoi...
webrtc/media/engine/webrtcvoiceengine.cc:1761: if (!default_sink_) {
On 2017/04/18 18:27:20, the sun wrote:
> Checking !unsignaled_recv_ssrcs_.empty() should be enough, if I'm not
mistaken.

The reason I check default_sink_ instead is that I want
"GetRtpReceiveParameters(0)" to return at least the codecs as long as an
"unsignaled stream AudioRtpReceiver" is configured. Which equates to
default_sink_ being non-null at this level.

In other words, "!default_sink_" is the equivalent to "it ==
recv_streams_.end()" for unsignaled streams; it means "not configured to play
out yet". Well, at least in Chrome.

[Taylor Brandstetter, 2017-04-20 07:17:15]

Description was changed from

==========
Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

When SSRCs aren't signaled, an SSRC of 0 is used internally to mean
"the default receive stream". But this wasn't working with the
implementation of GetRtpReceiveParameters in the audio/video
engines. This was breaking RtpReceiver.GetParameters in this situation,
as well as the new getStats implementation (which relies on
GetParameters).

The new implementation will fail if *no* default receive stream is
configured (meaning no default sink is set), and otherwise will return
a default RtpEncodingParameters, with the SSRC populated if known.

BUG=webrtc:6971
==========

to

==========
Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

When SSRCs aren't signaled, an SSRC of 0 is used internally to mean
"the default receive stream". But this wasn't working with the
implementation of GetRtpReceiveParameters in the audio/video
engines. This was breaking RtpReceiver.GetParameters in this situation,
as well as the new getStats implementation (which relies on
GetParameters).

The new implementation will fail if *no* default receive stream is
configured (meaning no default sink is set), and otherwise will return
a default RtpEncodingParameters (later it will be filled with relevant
SDP parameters as they're implemented).

BUG=webrtc:6971
==========

[pthatcher1, 2017-04-21 01:14:31]

lgtm

[Taylor Brandstetter, 2017-04-21 02:01:37]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-04-21 02:01:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-21 02:25:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492740097968400,
"parent_rev": "f96439a5dab01ef67d29f3fb88a9572751529744", "commit_rev":
"3bc15103aea1dd2fdfc01b833b62f34171c82e81"}

[commit-bot: I haz the power, 2017-04-21 02:25:12]

Description was changed from

==========
Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

When SSRCs aren't signaled, an SSRC of 0 is used internally to mean
"the default receive stream". But this wasn't working with the
implementation of GetRtpReceiveParameters in the audio/video
engines. This was breaking RtpReceiver.GetParameters in this situation,
as well as the new getStats implementation (which relies on
GetParameters).

The new implementation will fail if *no* default receive stream is
configured (meaning no default sink is set), and otherwise will return
a default RtpEncodingParameters (later it will be filled with relevant
SDP parameters as they're implemented).

BUG=webrtc:6971
==========

to

==========
Fix RtpReceiver.GetParameters when SSRCs aren't signaled.

When SSRCs aren't signaled, an SSRC of 0 is used internally to mean
"the default receive stream". But this wasn't working with the
implementation of GetRtpReceiveParameters in the audio/video
engines. This was breaking RtpReceiver.GetParameters in this situation,
as well as the new getStats implementation (which relies on
GetParameters).

The new implementation will fail if *no* default receive stream is
configured (meaning no default sink is set), and otherwise will return
a default RtpEncodingParameters (later it will be filled with relevant
SDP parameters as they're implemented).

BUG=webrtc:6971

Review-Url: https://codereview.webrtc.org/2806173002
Cr-Commit-Position: refs/heads/master@{#17803}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3bc15103aea1dd2fdfc01b833...
==========

[commit-bot: I haz the power, 2017-04-21 02:25:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3bc15103aea1dd2fdfc01b833...