APM-QA tool, renaming noise generators into input-reference generators.

APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise generator".
This naming is replaced with "input-reference generator" which is more descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with pylint.

BUG=webrtc:7218
Review-Url: https://codereview.webrtc.org/2805653002
Cr-Commit-Position: refs/heads/master@{#17639}
Committed: https://chromium.googlesource.com/external/webrtc/+/93cda2ebde909ad9cc424690f44f59a6fb84b149

[AleBzk, 2017-04-06 10:57:23]

Description was changed from

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218
==========

to

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218
==========

[AleBzk, 2017-04-06 10:57:23]

alessiob@webrtc.org changed reviewers:
+ peah@webrtc.org

[AleBzk, 2017-04-06 10:57:53]

Description was changed from

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218
==========

to

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218
NOTRY=True
==========

[AleBzk, 2017-04-06 11:02:29]

Hi Per,

This CL addresses your requests to change "noise generator" into something more
descriptive of the actual role. I used "input-reference generator" since a pair
of signals are in fact generated (the input and the reference) given a clean
input signal and a noise source.

Alessio

[peah-webrtc, 2017-04-07 13:02:12]

On 2017/04/06 11:02:29, AleBzk wrote:
> Hi Per,
> 
> This CL addresses your requests to change "noise generator" into something
more
> descriptive of the actual role. I used "input-reference generator" since a
pair
> of signals are in fact generated (the input and the reference) given a clean
> input signal and a noise source.
> 
> Alessio

Hi, 
Thanks for the CL. I don't think inref is a good acronym. To me it sounds like
input_reference and not input and reference. Also, does the python style guide
allow that nameing? Should it not then be in_ref_generator?

There must be a another way to name this. What about test_data_generator?

[AleBzk, 2017-04-10 12:57:22]

Hi again, as agreed offline, I went for test_data_generator.

[peah-webrtc, 2017-04-10 13:55:42]

On 2017/04/10 12:57:22, AleBzk wrote:
> Hi again, as agreed offline, I went for test_data_generator.

Nice!

lgtm with one question regarding the naming of one constant.

[peah-webrtc, 2017-04-10 13:55:42]

On 2017/04/10 12:57:22, AleBzk wrote:
> Hi again, as agreed offline, I went for test_data_generator.

Nice!

lgtm with one question regarding the naming of one constant.

[peah-webrtc, 2017-04-10 13:55:49]

https://codereview.webrtc.org/2805653002/diff/20001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py
(right):

https://codereview.webrtc.org/2805653002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py:27:

Is the INREF abbreaviation allowed by the style guideline?

[AleBzk, 2017-04-10 17:14:44]

Patchset #3 (id:40001) has been deleted

[AleBzk, 2017-04-10 17:15:52]

Description was changed from

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218
==========

[AleBzk, 2017-04-10 17:15:57]

The CQ bit was checked by alessiob@webrtc.org

[AleBzk, 2017-04-10 17:15:58]

The patchset sent to the CQ was uploaded after l-g-t-m from peah@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2805653002/#ps60001 (title:
"final changes")

[commit-bot: I haz the power, 2017-04-10 17:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[AleBzk, 2017-04-10 17:22:06]

Everything is now fixed, thanks! And sorry for INREF, that was something I
forgot to change.

https://codereview.webrtc.org/2805653002/diff/20001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py
(right):

https://codereview.webrtc.org/2805653002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py:27:

On 2017/04/10 13:55:49, peah-webrtc wrote:
> Is the INREF abbreaviation allowed by the style guideline?

Sorry, I missed this. It has to be renamed.

[commit-bot: I haz the power, 2017-04-10 19:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:16:32]

Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't started
yet, builder probably lacks capacity)

[AleBzk, 2017-04-11 08:03:26]

The CQ bit was checked by alessiob@webrtc.org

[commit-bot: I haz the power, 2017-04-11 08:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-11 08:06:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491897806449960,
"parent_rev": "97653704161c670d938ca7479361210fe0df5c11", "commit_rev":
"93cda2ebde909ad9cc424690f44f59a6fb84b149"}

[commit-bot: I haz the power, 2017-04-11 08:06:32]

Description was changed from

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218
==========

to

==========
APM-QA tool, renaming noise generators into input-reference generators.

This CL changes the name of classes, methods and variables making using "noise
generator".
This naming is replaced with "input-reference generator" which is more
descriptive of the actual role.
Comments, CSS class and HTML item names have also been changed.
Consistency for variable names has been verified and the style checked with
pylint.

BUG=webrtc:7218

Review-Url: https://codereview.webrtc.org/2805653002
Cr-Commit-Position: refs/heads/master@{#17639}
Committed:
https://chromium.googlesource.com/external/webrtc/+/93cda2ebde909ad9cc424690f...
==========

[commit-bot: I haz the power, 2017-04-11 08:06:33]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/93cda2ebde909ad9cc424690f...