Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2805653002: APM-QA tool, renaming noise generators into input-reference generators. (Closed)

Created:
3 years, 8 months ago by AleBzk
Modified:
3 years, 8 months ago
Reviewers:
peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

APM-QA tool, renaming noise generators into input-reference generators. This CL changes the name of classes, methods and variables making using "noise generator". This naming is replaced with "input-reference generator" which is more descriptive of the actual role. Comments, CSS class and HTML item names have also been changed. Consistency for variable names has been verified and the style checked with pylint. BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2805653002 Cr-Commit-Position: refs/heads/master@{#17639} Committed: https://chromium.googlesource.com/external/webrtc/+/93cda2ebde909ad9cc424690f44f59a6fb84b149

Patch Set 1 #

Patch Set 2 : in_ref_gen to test_data_gen #

Total comments: 2

Patch Set 3 : final changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -933 lines) Patch
M webrtc/modules/audio_processing/test/py_quality_assessment/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/README.md View 1 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py View 1 2 5 chunks +12 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.sh View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py View 1 2 5 chunks +32 lines, -27 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py View 1 2 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/export.py View 1 4 chunks +31 lines, -27 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py View 1 chunk +0 lines, -501 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation_factory.py View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation_unittest.py View 1 chunk +0 lines, -149 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/results.css View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/results.js View 1 4 chunks +17 lines, -16 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py View 1 2 8 chunks +39 lines, -35 lines 0 comments Download
A + webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py View 1 13 chunks +53 lines, -49 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation_factory.py View 1 1 chunk +41 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation_unittest.py View 1 6 chunks +53 lines, -52 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (11 generated)
AleBzk
Hi Per, This CL addresses your requests to change "noise generator" into something more descriptive ...
3 years, 8 months ago (2017-04-06 11:02:29 UTC) #4
peah-webrtc
On 2017/04/06 11:02:29, AleBzk wrote: > Hi Per, > > This CL addresses your requests ...
3 years, 8 months ago (2017-04-07 13:02:12 UTC) #5
AleBzk
Hi again, as agreed offline, I went for test_data_generator.
3 years, 8 months ago (2017-04-10 12:57:22 UTC) #6
peah-webrtc
On 2017/04/10 12:57:22, AleBzk wrote: > Hi again, as agreed offline, I went for test_data_generator. ...
3 years, 8 months ago (2017-04-10 13:55:42 UTC) #7
peah-webrtc
On 2017/04/10 12:57:22, AleBzk wrote: > Hi again, as agreed offline, I went for test_data_generator. ...
3 years, 8 months ago (2017-04-10 13:55:42 UTC) #8
peah-webrtc
https://codereview.webrtc.org/2805653002/diff/20001/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py File webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py (right): https://codereview.webrtc.org/2805653002/diff/20001/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py#newcode27 webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py:27: Is the INREF abbreaviation allowed by the style guideline?
3 years, 8 months ago (2017-04-10 13:55:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2805653002/60001
3 years, 8 months ago (2017-04-10 17:16:05 UTC) #14
AleBzk
Everything is now fixed, thanks! And sorry for INREF, that was something I forgot to ...
3 years, 8 months ago (2017-04-10 17:22:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-04-10 19:16:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2805653002/60001
3 years, 8 months ago (2017-04-11 08:03:32 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 08:06:33 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/93cda2ebde909ad9cc424690f...

Powered by Google App Engine
This is Rietveld 408576698