Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2804673002: Add [c]begin() and [c]end() member functions to rtc::Buffer (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ossu, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, henrika (OOO until Aug 14)
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add [c]begin() and [c]end() member functions to rtc::Buffer I can't believe it's been this long before I found out we didn't have them... BUG=none Review-Url: https://codereview.webrtc.org/2804673002 Cr-Commit-Position: refs/heads/master@{#17544} Committed: https://chromium.googlesource.com/external/webrtc/+/1ba21eb06339be822ab2074285efb6f2fdd6e2e9

Patch Set 1 #

Patch Set 2 : Remove redundant "this->" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M webrtc/base/buffer.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/base/buffer_unittest.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kwiberg-webrtc
3 years, 8 months ago (2017-04-05 13:11:55 UTC) #4
henrika_webrtc
lgtm
3 years, 8 months ago (2017-04-05 13:40:56 UTC) #5
ossu
lgtm
3 years, 8 months ago (2017-04-05 13:41:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2804673002/20001
3 years, 8 months ago (2017-04-05 13:54:26 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 14:38:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1ba21eb06339be822ab207428...

Powered by Google App Engine
This is Rietveld 408576698