Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 2804663002: Enabling 'gn check' on //webrtc/ortc. (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enabling 'gn check' on //webrtc/ortc. BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2804663002 Cr-Commit-Position: refs/heads/master@{#17642} Committed: https://chromium.googlesource.com/external/webrtc/+/cde2528d28b4ca354e1dbf27ace0922c91f42671

Patch Set 1 #

Patch Set 2 : Removing .gn to run chromium trybots #

Patch Set 3 : Revert "Removing .gn to run chromium trybots" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M .gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/ortc/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
mbonadei
3 years, 8 months ago (2017-04-05 12:48:22 UTC) #3
mbonadei
On 2017/04/05 12:48:22, mbonadei wrote: The error seem to be: Error: unrecognized flag -NSTreatUnknownArgumentsAsOpen I ...
3 years, 8 months ago (2017-04-05 14:11:12 UTC) #5
kjellander_webrtc
That's odd. I guess maybe it's safest to run all regular trybots on this one, ...
3 years, 8 months ago (2017-04-05 14:19:13 UTC) #7
Taylor Brandstetter
lgtm
3 years, 8 months ago (2017-04-05 17:32:31 UTC) #8
kjellander_webrtc
lgtm
3 years, 8 months ago (2017-04-11 08:27:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2804663002/40001
3 years, 8 months ago (2017-04-11 09:29:51 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 09:52:54 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/cde2528d28b4ca354e1dbf27a...

Powered by Google App Engine
This is Rietveld 408576698