Update stats for cpu/quality adaptation changes to excluded time when video is suspended.

Update stats for cpu/quality adaptation changes to excluded time when video is suspended.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2804653002
Cr-Commit-Position: refs/heads/master@{#17583}
Committed: https://chromium.googlesource.com/external/webrtc/+/0944a80f3e12fd877e5856e68d941699d8f3e8c3

[åsapersson, 2017-04-05 12:43:44]

Patchset #1 (id:1) has been deleted

[åsapersson, 2017-04-05 13:20:14]

Patchset #1 (id:20001) has been deleted

[åsapersson, 2017-04-05 14:42:25]

Patchset #1 (id:40001) has been deleted

[åsapersson, 2017-04-05 14:54:52]

Description was changed from

==========
Update stats for cpu/quality adaptation changes to excluded time when video is
suspended.

BUG=webrtc:6634
==========

to

==========
Update stats for cpu/quality adaptation changes to excluded time when video is
suspended.

BUG=webrtc:6634
==========

[åsapersson, 2017-04-05 14:54:52]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[åsapersson, 2017-04-06 12:16:38]

Patchset #1 (id:60001) has been deleted

[brandtr, 2017-04-07 06:42:02]

lgtm with nits

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.h:173: int quality_downscales_
GUARDED_BY(crit_) = -1;
No other members are initialized here, so probably better to move these 
initializations to the constructor too.

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy_unittest.cc:553: // Adapt changes: 2, elapsed
time: 20 ms.
Should this be seconds and not milliseconds?

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy_unittest.cc:564: // Adapt changes: 1, elapsed
time: 10 ms.
And here, and below?

[åsapersson, 2017-04-07 07:13:33]

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.h:173: int quality_downscales_
GUARDED_BY(crit_) = -1;
On 2017/04/07 06:42:02, brandtr wrote:
> No other members are initialized here, so probably better to move these 
> initializations to the constructor too.

Done.

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy_unittest.cc:553: // Adapt changes: 2, elapsed
time: 20 ms.
On 2017/04/07 06:42:02, brandtr wrote:
> Should this be seconds and not milliseconds?

Right, done.

https://codereview.webrtc.org/2804653002/diff/100001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy_unittest.cc:564: // Adapt changes: 1, elapsed
time: 10 ms.
On 2017/04/07 06:42:02, brandtr wrote:
> And here, and below?

Done.

[åsapersson, 2017-04-07 07:16:03]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 07:16:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-07 07:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 07:43:01]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)

[åsapersson, 2017-04-07 07:55:21]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-04-07 07:55:22]

The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2804653002/#ps120001 (title:
"address comments")

[commit-bot: I haz the power, 2017-04-07 07:55:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-07 07:57:59]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491551721973070,
"parent_rev": "533b7ac8e14a59ade4818f376d34c6986e7bfa1f", "commit_rev":
"0944a80f3e12fd877e5856e68d941699d8f3e8c3"}

[commit-bot: I haz the power, 2017-04-07 07:58:03]

Description was changed from

==========
Update stats for cpu/quality adaptation changes to excluded time when video is
suspended.

BUG=webrtc:6634
==========

to

==========
Update stats for cpu/quality adaptation changes to excluded time when video is
suspended.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2804653002
Cr-Commit-Position: refs/heads/master@{#17583}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0944a80f3e12fd877e5856e68...
==========

[commit-bot: I haz the power, 2017-04-07 07:58:04]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/0944a80f3e12fd877e5856e68...