Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2804013002: Changes construction of AudioTrack for API 21 and higher (Closed)

Created:
3 years, 8 months ago by henrika_webrtc
Modified:
3 years, 8 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, Taylor Brandstetter
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changes construction of AudioTrack for API 21 and higher. If we are on API level 21 or higher, it is possible to use a special AudioTrack constructor that uses AudioAttributes and AudioFormat as input. It allows us to supersede the notion of stream types for defining the behavior of audio playback, and to allow certain platforms or routing policies to use this information for more refined volume or routing decisions. BUG=b/30018586 Review-Url: https://codereview.webrtc.org/2804013002 Cr-Commit-Position: refs/heads/master@{#17737} Committed: https://chromium.googlesource.com/external/webrtc/+/90ee13ce1cede97006ea1fb1ca527a8333604a2a

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 1 3 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
henrika_webrtc
PTAL
3 years, 8 months ago (2017-04-06 14:19:17 UTC) #3
AlexG
lgtm
3 years, 8 months ago (2017-04-10 21:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2804013002/20001
3 years, 8 months ago (2017-04-18 11:42:06 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 12:07:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/90ee13ce1cede97006ea1fb1c...

Powered by Google App Engine
This is Rietveld 408576698