Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2803623004: Allow rtp::Packet::*RawExtension to take 0 as an extension id (Closed)

Created:
3 years, 8 months ago by danilchap
Modified:
3 years, 8 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow rtp::Packet::*RawExtension to take 0 as an extension id BUG=webrtc:7433 Review-Url: https://codereview.webrtc.org/2803623004 Cr-Commit-Position: refs/heads/master@{#17610} Committed: https://chromium.googlesource.com/external/webrtc/+/c547e84ec5b935151a8fe9797f283665b660dd24

Patch Set 1 #

Patch Set 2 : +AllocateRawExtension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 1 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
danilchap
3 years, 8 months ago (2017-04-06 11:18:13 UTC) #2
nisse-webrtc
lgtm
3 years, 8 months ago (2017-04-10 06:58:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2803623004/20001
3 years, 8 months ago (2017-04-10 07:40:31 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 08:31:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c547e84ec5b935151a8fe9797...

Powered by Google App Engine
This is Rietveld 408576698