Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2802603003: Make GetConfig() part of the AudioProcessing interface (Closed)

Created:
3 years, 8 months ago by hlundin-webrtc
Modified:
3 years, 8 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make GetConfig() part of the AudioProcessing interface BUG=chromium:708475 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.webrtc.org/2802603003 Cr-Commit-Position: refs/heads/master@{#17540} Committed: https://chromium.googlesource.com/external/webrtc/+/adf0635ed54f5c7b87c8d2ee774f2a5bbf6f1828

Patch Set 1 #

Patch Set 2 : Make the method non-pure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
hlundin-webrtc
Per, PTAL.
3 years, 8 months ago (2017-04-05 10:00:26 UTC) #3
peah-webrtc
Awesome! lgtm
3 years, 8 months ago (2017-04-05 10:03:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2802603003/20001
3 years, 8 months ago (2017-04-05 12:18:07 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 12:48:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/adf0635ed54f5c7b87c8d2ee7...

Powered by Google App Engine
This is Rietveld 408576698