Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2801733002: Move rtp header extension length check from Packet::FindExtension to ExtensionT::Parse (Closed)

Created:
3 years, 8 months ago by danilchap
Modified:
3 years, 8 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move rtp header extension length check from Packet::FindExtension to ExtensionT::Parse to allow to read variable-length extensions. BUG=webrtc:7433 Review-Url: https://codereview.webrtc.org/2801733002 Cr-Commit-Position: refs/heads/master@{#17554} Committed: https://chromium.googlesource.com/external/webrtc/+/978504e25cafc1ce59cf7fbcace3a331a9b98112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -45 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 7 chunks +9 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 7 chunks +30 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 2 chunks +7 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
3 years, 8 months ago (2017-04-05 17:09:59 UTC) #2
nisse-webrtc
LGTM. This is in preparation for variable-length extensions?
3 years, 8 months ago (2017-04-06 06:56:22 UTC) #3
danilchap
On 2017/04/06 06:56:22, nisse-webrtc wrote: > LGTM. > > This is in preparation for variable-length ...
3 years, 8 months ago (2017-04-06 07:36:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2801733002/1
3 years, 8 months ago (2017-04-06 07:36:54 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 08:03:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/978504e25cafc1ce59cf7fbca...

Powered by Google App Engine
This is Rietveld 408576698