Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2801293002: Add some unit tests to vie_encoder. (Closed)

Created:
3 years, 8 months ago by åsapersson
Modified:
3 years, 8 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add some unit tests to vie_encoder. BUG=none Review-Url: https://codereview.webrtc.org/2801293002 Cr-Commit-Position: refs/heads/master@{#17609} Committed: https://chromium.googlesource.com/external/webrtc/+/02465b8a11dd7a8d9cd3d26cfdd3d0cd2e4f8782

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -67 lines) Patch
M webrtc/video/vie_encoder.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 19 chunks +161 lines, -55 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
åsapersson
3 years, 8 months ago (2017-04-07 15:31:07 UTC) #5
brandtr
lgtm! https://codereview.webrtc.org/2801293002/diff/40001/webrtc/video/vie_encoder_unittest.cc File webrtc/video/vie_encoder_unittest.cc (right): https://codereview.webrtc.org/2801293002/diff/40001/webrtc/video/vie_encoder_unittest.cc#newcode833 webrtc/video/vie_encoder_unittest.cc:833: // Turn of degradation completely. "off"
3 years, 8 months ago (2017-04-10 07:06:07 UTC) #6
åsapersson
https://codereview.webrtc.org/2801293002/diff/40001/webrtc/video/vie_encoder_unittest.cc File webrtc/video/vie_encoder_unittest.cc (right): https://codereview.webrtc.org/2801293002/diff/40001/webrtc/video/vie_encoder_unittest.cc#newcode833 webrtc/video/vie_encoder_unittest.cc:833: // Turn of degradation completely. On 2017/04/10 07:06:07, brandtr ...
3 years, 8 months ago (2017-04-10 07:31:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2801293002/60001
3 years, 8 months ago (2017-04-10 07:32:01 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 08:12:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/02465b8a11dd7a8d9cd3d26cf...

Powered by Google App Engine
This is Rietveld 408576698