Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2800853006: Address tkchin's comments on RTCCameraVideoCapturer. (Closed)

Created:
3 years, 8 months ago by sakal
Modified:
3 years, 7 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Address tkchin's comments on RTCCameraVideoCapturer. BUG=webrtc:7177 Review-Url: https://codereview.webrtc.org/2800853006 Cr-Commit-Position: refs/heads/master@{#17986} Committed: https://chromium.googlesource.com/external/webrtc/+/cee5141eb0b77739dad0d3f0707425f71ee472fe

Patch Set 1 #

Patch Set 2 : Move check code to RTCDispatcher. #

Total comments: 2

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m View 1 3 chunks +6 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCDispatcher.m View 1 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCCameraVideoCapturer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sakal
PTAL
3 years, 8 months ago (2017-04-07 10:31:53 UTC) #3
tkchin_webrtc
lgtm https://codereview.webrtc.org/2800853006/diff/20001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h (right): https://codereview.webrtc.org/2800853006/diff/20001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h#newcode40 webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h:40: /** Returns true if run on queue for ...
3 years, 8 months ago (2017-04-12 22:01:42 UTC) #4
sakal
https://codereview.webrtc.org/2800853006/diff/20001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h (right): https://codereview.webrtc.org/2800853006/diff/20001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h#newcode40 webrtc/sdk/objc/Framework/Headers/WebRTC/RTCDispatcher.h:40: /** Returns true if run on queue for the ...
3 years, 8 months ago (2017-04-19 08:59:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2800853006/40001
3 years, 7 months ago (2017-05-03 10:30:06 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 10:50:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/cee5141eb0b77739dad0d3f07...

Powered by Google App Engine
This is Rietveld 408576698