Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 2800813005: Enable tools_unittests and rtc_stats_unittests on iOS Simulator (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc
Modified:
3 years, 8 months ago
Reviewers:
oprypin_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable tools_unittests and rtc_stats_unittests on iOS Simulator The tests have been passing for some time, but were never added. BUG=webrtc:5572, webrtc:5566 NOTRY=True Review-Url: https://codereview.webrtc.org/2800813005 Cr-Commit-Position: refs/heads/master@{#17556} Committed: https://chromium.googlesource.com/external/webrtc/+/b1e3fc4515a4d3cfb0078357bf133e90c15db9a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools-webrtc/ios/tests/common_tests.json View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
3 years, 8 months ago (2017-04-06 08:41:58 UTC) #2
oprypin_webrtc
lgtm
3 years, 8 months ago (2017-04-06 08:44:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2800813005/1
3 years, 8 months ago (2017-04-06 08:46:27 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 08:48:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b1e3fc4515a4d3cfb0078357b...

Powered by Google App Engine
This is Rietveld 408576698