Chromium Code Reviews

Issue 2799813002: Fixed error for missing explict class initialization error on iOS WebRTC buildbots (Closed)

Created:
3 years, 8 months ago by peah-webrtc
Modified:
3 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed error for missing explicit class initialization error on iOS buildbots TBR=henrik.lundin@webrtc.org BUG=webrtc:6018 Review-Url: https://codereview.webrtc.org/2799813002 Cr-Commit-Position: refs/heads/master@{#17549} Committed: https://chromium.googlesource.com/external/webrtc/+/5ac18af71b0805678fcf78b32b3c7d6aa62bea71

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -1 line)
M webrtc/modules/audio_processing/aec3/render_buffer.cc View 1 chunk +2 lines, -1 line 0 comments

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2799813002/1
3 years, 8 months ago (2017-04-05 21:48:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/5ac18af71b0805678fcf78b32b3c7d6aa62bea71
3 years, 8 months ago (2017-04-05 22:10:42 UTC) #7
guidou
3 years, 8 months ago (2017-04-06 04:27:53 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2803933002/ by guidou@webrtc.org.

The reason for reverting is: Causes compile error on iOS.
export
DEVELOPER_DIR=/b/build/slave/ios-device-xcode-clang/build/src/build/ios_files/Xcode.app;
 /b/build/slave/cache/goma_client/gomacc clang++ -MMD -MF
obj/third_party/webrtc/modules/audio_processing/audio_processing/render_buffer.o.d
-DWEBRTC_APM_DEBUG_DUMP=0 -DWEBRTC_AUDIOPROC_DEBUG_DUMP
-DWEBRTC_INTELLIGIBILITY_ENHANCER=0 -DWEBRTC_NS_FIXED -DV8_DEPRECATION_WARNINGS
-DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=\"298539-1\" -DCR_XCODE_VERSION=0821
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNS_BLOCK_ASSERTIONS=1
-DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH -DHAVE_SCTP
-DENABLE_EXTERNAL_AUTH -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE
-DLOGGING_INSIDE_WEBRTC -DUSE_WEBRTC_DEV_BRANCH -DWEBRTC_ARCH_ARM
-DWEBRTC_ARCH_ARM_V7 -DWEBRTC_HAS_NEON -DFEATURE_ENABLE_VOICEMAIL
-DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_SOUND_SYSTEM
-DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DWEBRTC_IOS
-DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD
-I../.. -Igen -I../../third_party/webrtc_overrides -I../../third_party
-I../../third_party
-I../../third_party/webrtc/modules/audio_coding/codecs/isac/main/include
-I../../third_party/protobuf/src -Igen/protoc_out
-I../../third_party/protobuf/src
-I../../third_party/webrtc/common_audio/resampler/include
-I../../third_party/webrtc/common_audio/signal_processing/include
-I../../third_party/webrtc/common_audio/vad/include -fno-strict-aliasing
--param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined
-D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -arch armv7 -Wall
-Werror -Wextra -Wundeclared-selector -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Os
-gdwarf-2 -isysroot
/b/build/slave/ios-device-xcode-clang/build/src/build/ios_files/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.2.sdk
-stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Wheader-hygiene
-Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden
-std=c++11 -fno-rtti -fno-exceptions -c
../../third_party/webrtc/modules/audio_processing/aec3/render_buffer.cc -o
obj/third_party/webrtc/modules/audio_processing/audio_processing/render_buffer.o
../../third_party/webrtc/modules/audio_processing/aec3/render_buffer.cc:20:15:
error: constructor for 'webrtc::RenderBuffer' must explicitly initialize the
const member 'fft_'
RenderBuffer::RenderBuffer(Aec3Optimization optimization,
              ^
../../third_party/webrtc/modules/audio_processing/aec3/render_buffer.h:75:17:
note: 'fft_' declared here
  const Aec3Fft fft_;
                ^

See
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2....

Powered by Google App Engine