Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2799633002: Enabling 'gn check' on //webrtc/tools. (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enabling 'gn check' on //webrtc/tools. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2799633002 Cr-Commit-Position: refs/heads/master@{#17542} Committed: https://chromium.googlesource.com/external/webrtc/+/129fc9ce9402c445184edcc1053b1864d9428771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mbonadei
3 years, 8 months ago (2017-04-05 13:22:44 UTC) #2
mbonadei
3 years, 8 months ago (2017-04-05 13:22:45 UTC) #3
kjellander_webrtc
Excellent, thanks!
3 years, 8 months ago (2017-04-05 14:09:20 UTC) #4
kjellander_webrtc
lgtm
3 years, 8 months ago (2017-04-05 14:09:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2799633002/1
3 years, 8 months ago (2017-04-05 14:12:00 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 14:14:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/129fc9ce9402c445184edcc10...

Powered by Google App Engine
This is Rietveld 408576698