Injectable audio encoders: Moved audio encoder, factory and builtin factory to api/.

Injectable audio encoders: Moved audio encoder, factory and builtin factory to api/.

Plumbed AudioEncoderFactory up into CreatePeerConnectionFactory.

BUG=webrtc:5806
Review-Url: https://codereview.webrtc.org/2799033006
Cr-Commit-Position: refs/heads/master@{#17977}
Committed: https://chromium.googlesource.com/external/webrtc/+/eb1fde4a26f1a863c7488a63923eaf782c3ba177

[ossu, 2017-04-10 14:01:54]

Description was changed from

==========
Injectable audio encoders: Moved audio encoder, factory and builtin factory to
api/.

Plumbed Audio{En,De}coderFactory up into CreatePeerConnectionFactory.

BUG=webrtc:5806
==========

to

==========
Injectable audio encoders: Moved audio encoder, factory and builtin factory to
api/.

Plumbed AudioEncoderFactory up into CreatePeerConnectionFactory.

BUG=webrtc:5806
==========

[ossu, 2017-04-10 16:01:43]

Patchset #1 (id:1) has been deleted

[ossu, 2017-04-11 13:45:01]

ossu@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[ossu, 2017-04-11 13:45:02]

Adding kwiberg@ to have a look at this one. Don't worry, it looks bigger than it
is. :)

Still need 2705093002 to land first, though. Any more comments on that one?

[kwiberg-webrtc, 2017-04-12 09:59:33]

lgtm

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface.h:77: // TODO(ossu): Remove this once
downstream projects have been updated.
Sorry, it's my fault that you have to do this...

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcmediaengine.h (right):

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcmediaengine.h:77:
rtc::scoped_refptr<webrtc::AudioMixer> audio_mixer);
Any chance you could add the new argument to the existing overloads instead?

[ossu, 2017-04-12 10:05:28]

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface.h:77: // TODO(ossu): Remove this once
downstream projects have been updated.
On 2017/04/12 09:59:33, kwiberg-webrtc wrote:
> Sorry, it's my fault that you have to do this...

Yeah, I realized that had we put the stubs in the proper header files from the
start, it would have JustWorked(tm) when I updated them.

This should be pretty quick. Any downstream projects would've required changing
with this move anyways.

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcmediaengine.h (right):

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcmediaengine.h:77:
rtc::scoped_refptr<webrtc::AudioMixer> audio_mixer);
On 2017/04/12 09:59:33, kwiberg-webrtc wrote:
> Any chance you could add the new argument to the existing overloads instead?

Maybe. I'll try to see if any downstream projects are using this directly, so I
don't break them.

[ossu, 2017-04-27 15:10:39]

Patchset #2 (id:40001) has been deleted

[ossu, 2017-04-27 15:41:19]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 15:41:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-27 16:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:06:16]

Dry run: This issue passed the CQ dry run.

[ossu, 2017-04-28 12:56:12]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 12:56:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-28 13:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 13:24:55]

Dry run: This issue passed the CQ dry run.

[ossu, 2017-04-28 14:33:47]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 14:33:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-28 15:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:47:55]

Dry run: This issue passed the CQ dry run.

[ossu, 2017-05-02 11:14:51]

Seems the internal bot is in a bit of a bad mood ATM, but at least it builds
alright now. The error looks like a flake. I'm rerunning just in case. Will land
this unless something new turns up.

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcmediaengine.h (right):

https://codereview.webrtc.org/2799033006/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcmediaengine.h:77:
rtc::scoped_refptr<webrtc::AudioMixer> audio_mixer);
On 2017/04/12 10:05:28, ossu wrote:
> On 2017/04/12 09:59:33, kwiberg-webrtc wrote:
> > Any chance you could add the new argument to the existing overloads instead?
> 
> Maybe. I'll try to see if any downstream projects are using this directly, so
I
> don't break them.

Just tried it. They were, so I'm going to have to keep all these overloads. I
should be able to clean this up while removing the need for the extra include in
peerconnectioninteface.h.

[ossu, 2017-05-02 12:50:52]

The CQ bit was checked by ossu@webrtc.org

[ossu, 2017-05-02 12:50:53]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2799033006/#ps140001 (title:
"More backwards-compatibility!")

[commit-bot: I haz the power, 2017-05-02 12:50:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-02 13:46:31]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493729452835310,
"parent_rev": "c50105db356d38d219c06e258b72bb708cf7d991", "commit_rev":
"eb1fde4a26f1a863c7488a63923eaf782c3ba177"}

[commit-bot: I haz the power, 2017-05-02 13:46:35]

Description was changed from

==========
Injectable audio encoders: Moved audio encoder, factory and builtin factory to
api/.

Plumbed AudioEncoderFactory up into CreatePeerConnectionFactory.

BUG=webrtc:5806
==========

to

==========
Injectable audio encoders: Moved audio encoder, factory and builtin factory to
api/.

Plumbed AudioEncoderFactory up into CreatePeerConnectionFactory.

BUG=webrtc:5806

Review-Url: https://codereview.webrtc.org/2799033006
Cr-Commit-Position: refs/heads/master@{#17977}
Committed:
https://chromium.googlesource.com/external/webrtc/+/eb1fde4a26f1a863c7488a639...
==========

[commit-bot: I haz the power, 2017-05-02 13:46:37]

Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/eb1fde4a26f1a863c7488a639...