Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2796353002: Delete system_wrappers logging facility. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
Reviewers:
the sun, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete system_wrappers logging facility. BUG=webrtc:5118 Review-Url: https://codereview.webrtc.org/2796353002 Cr-Commit-Position: refs/heads/master@{#17561} Committed: https://chromium.googlesource.com/external/webrtc/+/639d46a7ab2e6fbecd3fc835d0f161c6e854d2b4

Patch Set 1 #

Patch Set 2 : Fix android build. #

Patch Set 3 : Rebase, and update include in aec3 code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -258 lines) Patch
M webrtc/modules/audio_processing/aec3/render_delay_buffer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
D webrtc/system_wrappers/include/logging.h View 1 chunk +0 lines, -132 lines 0 comments Download
M webrtc/system_wrappers/source/logcat_trace_context.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D webrtc/system_wrappers/source/logging.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/system_wrappers/source/logging_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
nisse-webrtc
Follow up cl to delete system_wrappers/*/logging*.
3 years, 8 months ago (2017-04-05 12:25:07 UTC) #2
the sun
LGTM!
3 years, 8 months ago (2017-04-05 13:11:08 UTC) #3
kwiberg-webrtc
lgtm
3 years, 8 months ago (2017-04-05 23:28:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2796353002/40001
3 years, 8 months ago (2017-04-06 10:49:14 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 10:53:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/639d46a7ab2e6fbecd3fc835d...

Powered by Google App Engine
This is Rietveld 408576698