Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2796223004: Make AudioProcessing::GetConfig() pure virtual (Closed)

Created:
3 years, 8 months ago by hlundin-webrtc
Modified:
3 years, 8 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make AudioProcessing::GetConfig() pure virtual BUG=chromium:708475 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.webrtc.org/2796223004 Cr-Commit-Position: refs/heads/master@{#17581} Committed: https://chromium.googlesource.com/external/webrtc/+/77492860a9d332079fc887740d3254ed0fdcb543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hlundin-webrtc
peah, ptal. Thanks!
3 years, 8 months ago (2017-04-06 19:53:57 UTC) #3
peah-webrtc
On 2017/04/06 19:53:57, hlundin-webrtc wrote: > peah, ptal. > > Thanks! lgtm
3 years, 8 months ago (2017-04-06 21:58:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2796223004/1
3 years, 8 months ago (2017-04-07 05:50:06 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 06:28:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/77492860a9d332079fc887740...

Powered by Google App Engine
This is Rietveld 408576698