Simplify RTPSender::RegisterRtpHeaderExtension

Simplify RTPSender::RegisterRtpHeaderExtension
DCHECK instead of run-time check extension type is correct.

BUG=webrtc:1994
Review-Url: https://codereview.webrtc.org/2795723002
Cr-Commit-Position: refs/heads/master@{#17524}
Committed: https://chromium.googlesource.com/external/webrtc/+/fab482b32684b65f2ad9c6c7a967a4802dacff82

[danilchap, 2017-04-03 15:45:10]

danilchap@webrtc.org changed reviewers:
+ nisse@webrtc.org

[danilchap, 2017-04-03 15:45:11]

overdue cleanup

[danilchap, 2017-04-03 15:45:31]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 15:45:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-03 15:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 15:47:26]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/24486)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/23303)

[danilchap, 2017-04-03 16:08:51]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 16:08:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-03 16:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 16:31:18]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-04-04 09:29:20]

lgtm

What would it take to clean up the interface of this function too? It would be
preferable with an int for the |id| input (according to earlier discussion), and
bool return value. RtpHeaderExtensionMap seems to use uint8_t for id:s, though.

[danilchap, 2017-04-04 09:31:04]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-04-04 09:31:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-04 09:33:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491298264064970, "parent_rev":
"55a01354841fa9ab2bcbb4623c1176dfc560fbdc", "commit_rev":
"fab482b32684b65f2ad9c6c7a967a4802dacff82"}

[commit-bot: I haz the power, 2017-04-04 09:33:52]

Description was changed from

==========
Simplify RTPSender::RegisterRtpHeaderExtension
DCHECK instead of run-time check extension type is correct.

BUG=webrtc:1994
==========

to

==========
Simplify RTPSender::RegisterRtpHeaderExtension
DCHECK instead of run-time check extension type is correct.

BUG=webrtc:1994

Review-Url: https://codereview.webrtc.org/2795723002
Cr-Commit-Position: refs/heads/master@{#17524}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fab482b32684b65f2ad9c6c7a...
==========

[commit-bot: I haz the power, 2017-04-04 09:33:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fab482b32684b65f2ad9c6c7a...