Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2795693003: Make RtpTransportControllerSend::send_side_cc_ a direct member. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make RtpTransportControllerSend::send_side_cc_ a direct member. Now constructed early, and Call uses RegisterNetworkObserver. BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/2795693003 Cr-Commit-Position: refs/heads/master@{#17566} Committed: https://chromium.googlesource.com/external/webrtc/+/6167b2621fcd1790e70c2306906661e520309dee

Patch Set 1 #

Patch Set 2 : Fixed nullptr error in initialization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M webrtc/call/call.cc View 1 4 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nisse-webrtc
PTAL.
3 years, 8 months ago (2017-04-04 12:42:17 UTC) #2
stefan-webrtc
lgtm
3 years, 8 months ago (2017-04-06 12:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2795693003/20001
3 years, 8 months ago (2017-04-06 12:47:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/12702)
3 years, 8 months ago (2017-04-06 13:08:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2795693003/20001
3 years, 8 months ago (2017-04-06 13:27:11 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 13:34:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/6167b2621fcd1790e70c23069...

Powered by Google App Engine
This is Rietveld 408576698