Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2795683002: Revert of Add empty header to fix internal project. (Closed)

Created:
3 years, 8 months ago by kthelgason
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add empty header to fix internal project. (patchset #1 id:1 of https://codereview.webrtc.org/2790493006/ ) Reason for revert: Internal dependency has been removed. Original issue's description: > Add empty header to fix internal project. > > BUG=None > TBR=tommi@webrtc.org > > Review-Url: https://codereview.webrtc.org/2790493006 > Cr-Commit-Position: refs/heads/master@{#17492} > Committed: https://chromium.googlesource.com/external/webrtc/+/16d5bae3963950082447dad230f827a134f0cc68 TBR=kjellander@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.webrtc.org/2795683002 Cr-Commit-Position: refs/heads/master@{#17503} Committed: https://chromium.googlesource.com/external/webrtc/+/d197cd9ad94b1b9b59b6f54e19694ff9a9d3ac4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
D webrtc/system_wrappers/include/critical_section_wrapper.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kthelgason
Created Revert of Add empty header to fix internal project.
3 years, 8 months ago (2017-04-03 09:10:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2795683002/1
3 years, 8 months ago (2017-04-03 09:11:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d197cd9ad94b1b9b59b6f54e19694ff9a9d3ac4e
3 years, 8 months ago (2017-04-03 09:33:37 UTC) #6
kjellander_webrtc
3 years, 8 months ago (2017-04-03 11:29:28 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698