Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2795103002:
Trivial data() and mutable_data() implementations (Closed)
DescriptionTrivial data() and mutable_data() implementations
This will allow migrating existing references to data_ over to data() and
mutable_data(), so that https://codereview.webrtc.org/2750783004/ can be
imported cleanly.
BUG=webrtc:7343
TBR=henrika@webrtc.org
Review-Url: https://codereview.webrtc.org/2795103002
Cr-Commit-Position: refs/heads/master@{#17532}
Committed: https://chromium.googlesource.com/external/webrtc/+/ba13131f9ab61ebfbb4a8abcd8c75e66b160a9c4
Patch Set 1 #Patch Set 2 : Merge latest #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by yujo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
yujo@chromium.org changed reviewers: + henrik.lundin@webrtc.org, solenberg@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
Description was changed from ========== Trivial data() and mutable_data() implementations This will allow migrating existing references to data_ over to data() and mutable_data(), so that https://codereview.webrtc.org/2750783004/ can be imported cleanly. BUG=webrtc:7343 ========== to ========== Trivial data() and mutable_data() implementations This will allow migrating existing references to data_ over to data() and mutable_data(), so that https://codereview.webrtc.org/2750783004/ can be imported cleanly. BUG=webrtc:7343 ==========
yujo@chromium.org changed reviewers: + henrika@webrtc.org
+henrika for OWNERS
Description was changed from ========== Trivial data() and mutable_data() implementations This will allow migrating existing references to data_ over to data() and mutable_data(), so that https://codereview.webrtc.org/2750783004/ can be imported cleanly. BUG=webrtc:7343 ========== to ========== Trivial data() and mutable_data() implementations This will allow migrating existing references to data_ over to data() and mutable_data(), so that https://codereview.webrtc.org/2750783004/ can be imported cleanly. BUG=webrtc:7343 TBR=henrika@webrtc.org ==========
The CQ bit was checked by henrik.lundin@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org, henrik.lundin@webrtc.org Link to the patchset: https://codereview.webrtc.org/2795103002/#ps20001 (title: "Merge latest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491336931608870,
"parent_rev": "baf9b58cb4a9ee1ed62936d516080bd300de99ed", "commit_rev":
"ba13131f9ab61ebfbb4a8abcd8c75e66b160a9c4"}
Message was sent while issue was closed.
Description was changed from ========== Trivial data() and mutable_data() implementations This will allow migrating existing references to data_ over to data() and mutable_data(), so that https://codereview.webrtc.org/2750783004/ can be imported cleanly. BUG=webrtc:7343 TBR=henrika@webrtc.org ========== to ========== Trivial data() and mutable_data() implementations This will allow migrating existing references to data_ over to data() and mutable_data(), so that https://codereview.webrtc.org/2750783004/ can be imported cleanly. BUG=webrtc:7343 TBR=henrika@webrtc.org Review-Url: https://codereview.webrtc.org/2795103002 Cr-Commit-Position: refs/heads/master@{#17532} Committed: https://chromium.googlesource.com/external/webrtc/+/ba13131f9ab61ebfbb4a8abcd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/ba13131f9ab61ebfbb4a8abcd...
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
