Chromium Code Reviews

Issue 2794193003: Move SelectMediaType from RampUpTester to BaseTest. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move SelectMediaType from RampUpTester to BaseTest. This provides a better default for audio-only tests. BUG=None Review-Url: https://codereview.webrtc.org/2794193003 Cr-Commit-Position: refs/heads/master@{#17536} Committed: https://chromium.googlesource.com/external/webrtc/+/d8ce1e172e2bb3978f9b52d2373f2ccb8ccc1c16

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+19 lines, -25 lines)
M webrtc/call/rampup_tests.h View 1 chunk +0 lines, -2 lines 0 comments
M webrtc/call/rampup_tests.cc View 2 chunks +0 lines, -20 lines 0 comments
M webrtc/test/call_test.h View 1 chunk +4 lines, -1 line 0 comments
M webrtc/test/call_test.cc View 1 chunk +15 lines, -2 lines 0 comments

Messages

Total messages: 8 (4 generated)
nisse-webrtc
PTAL.
3 years, 8 months ago (2017-04-05 07:00:01 UTC) #2
stefan-webrtc
lgtm
3 years, 8 months ago (2017-04-05 07:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2794193003/1
3 years, 8 months ago (2017-04-05 07:10:58 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 07:33:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d8ce1e172e2bb3978f9b52d23...

Powered by Google App Engine