Issue 2794193002: [iOS] Changed ptr to const ref for RTCConfiguration initialization

Issue 2794193002: [iOS] Changed ptr to const ref for RTCConfiguration initialization (Closed)

Created:
3 years, 8 months ago by jtt_webrtc

Modified:
3 years, 8 months ago

Reviewers:
tkchin_webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

[iOS] Changed ptr to const ref for RTCConfiguration initialization BUG=webrtc:7431 Review-Url: https://codereview.webrtc.org/2794193002 Cr-Commit-Position: refs/heads/master@{#17533} Committed: https://chromium.googlesource.com/external/webrtc/+/465faf0061131100774503f9110abbc130092dcf

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm	View	1 chunk	+18 lines, -19 lines	0 comments	Download
M	webrtc/sdk/objc/Framework/Classes/RTCConfiguration+Private.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 8 (4 generated)

jtt_webrtc

As per your suggestion to change the pointers to const ref.

3 years, 8 months ago (2017-04-04 16:11:50 UTC) #2

tkchin_webrtc

On 2017/04/04 16:11:50, jtt wrote: > As per your suggestion to change the pointers to ...

3 years, 8 months ago (2017-04-04 20:13:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2794193002/1

3 years, 8 months ago (2017-04-04 20:21:15 UTC) #5

commit-bot: I haz the power

3 years, 8 months ago (2017-04-04 21:00:22 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/465faf0061131100774503f91...