Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: webrtc/pc/peerconnectioninterface_unittest.cc

Issue 2793913008: Add PeerConnectionInterface::UpdateCallBitrate. (Closed)
Patch Set: add an error message and clarify test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/pc/peerconnection.cc ('K') | « webrtc/pc/peerconnection.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/peerconnectioninterface_unittest.cc
diff --git a/webrtc/pc/peerconnectioninterface_unittest.cc b/webrtc/pc/peerconnectioninterface_unittest.cc
index 05d53ad1a153fdcacc66f240d706c88f69d51f64..2a21f3ce8f69758c6d9c5eee75c8b37c6e9d06fd 100644
--- a/webrtc/pc/peerconnectioninterface_unittest.cc
+++ b/webrtc/pc/peerconnectioninterface_unittest.cc
@@ -3286,6 +3286,15 @@ TEST_F(PeerConnectionInterfaceTest,
EXPECT_TRUE(DoSetLocalDescription(answer.release()));
}
+TEST_F(PeerConnectionInterfaceTest, UpdateCallBitrateWithoutMinSucceeds) {
+ CreatePeerConnection();
+ PeerConnectionInterface::BitrateUpdate update;
+ update.start_bitrate_bps = rtc::Optional<int>(100000);
+ // Call doesn't expose its current config, so we just check that the
+ // call succeeds here.
+ pc_->UpdateCallBitrate(update);
Taylor Brandstetter 2017/04/07 03:29:12 This test doesn't have any expectations, so is it
Zach Stein 2017/04/09 21:09:01 The comment on 3293-3294 was my attempt to explain
Taylor Brandstetter 2017/04/10 04:59:51 That would be fine.
+}
+
class PeerConnectionMediaConfigTest : public testing::Test {
protected:
void SetUp() override {
« webrtc/pc/peerconnection.cc ('K') | « webrtc/pc/peerconnection.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698