Add PeerConnectionInterface::UpdateCallBitrate.

webrtc/pc/peerconnectioninterface_unittest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 3268 matching lines @@
   std::unique_ptr<SessionDescriptionInterface> offer;
   ASSERT_TRUE(DoCreateOffer(&offer, nullptr));
   EXPECT_TRUE(DoSetRemoteDescription(offer.release()));
 
   // Create and set answer as well.
   std::unique_ptr<SessionDescriptionInterface> answer;
   ASSERT_TRUE(DoCreateAnswer(&answer, nullptr));
   EXPECT_TRUE(DoSetLocalDescription(answer.release()));
 }
 
+TEST_F(PeerConnectionInterfaceTest, UpdateCallBitrateWithoutMinSucceeds) {
+  CreatePeerConnection();
+  PeerConnectionInterface::BitrateUpdate update;
+  update.start_bitrate_bps = rtc::Optional<int>(100000);
+  // Call doesn't expose its current config, so we just check that the
+  // call succeeds here.
+  pc_->UpdateCallBitrate(update);

[Taylor Brandstetter, 2017/04/07 03:29:12]

This test doesn't have any expectations, so is it mainly to verify that nothing
crashes? I'd mention that in a comment.

Can you also add a TODO to add a more meaningful test for this? I don't think
there's any easy way right now; the best we could do would probably be allowing
a "FakeCall" to be injected into PeerConnection (which we do in other places).

[Zach Stein, 2017/04/09 21:09:01]

The comment on 3293-3294 was my attempt to explain the lack of EXPECTs.

Should I just put the TODO after this test case?

[Taylor Brandstetter, 2017/04/10 04:59:51]

That would be fine.

+}
+
 class PeerConnectionMediaConfigTest : public testing::Test {
  protected:
   void SetUp() override {
     pcf_ = new rtc::RefCountedObject<PeerConnectionFactoryForTest>();
     pcf_->Initialize();
   }
   const cricket::MediaConfig& TestCreatePeerConnection(
       const PeerConnectionInterface::RTCConfiguration& config,
       const MediaConstraintsInterface *constraints) {
     pcf_->create_media_controller_called_ = false;
@@ skipping 274 matching lines @@
   EXPECT_NE(a, f);
 
   PeerConnectionInterface::RTCConfiguration g;
   g.disable_ipv6 = true;
   EXPECT_NE(a, g);
 
   PeerConnectionInterface::RTCConfiguration h(
       PeerConnectionInterface::RTCConfigurationType::kAggressive);
   EXPECT_NE(a, h);
 }