Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2793903006: Style fix and docstring for the APM QA Python tool (Closed)

Created:
3 years, 8 months ago by AleBzk
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

This CL fixes the following: - snake_case -> CapWords - compulsory docstring added - style A followup CL will fix remaining issues as raised by the next version of the WebRTC Python linter (update in progress). BUG=webrtc:7218 NOTRY=True Review-Url: https://codereview.webrtc.org/2793903006 Cr-Commit-Position: refs/heads/master@{#17543} Committed: https://chromium.googlesource.com/external/webrtc/+/dea682d25b60820af862cfb8f35a761ef1597784

Patch Set 1 : snake_case to CapWords #

Patch Set 2 : missing docstring and style fix #

Total comments: 2

Patch Set 3 : _ prefix for internal use functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -268 lines) Patch
M webrtc/modules/audio_processing/test/py_quality_assessment/README.md View 1 1 chunk +9 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py View 1 2 5 chunks +36 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py View 1 2 5 chunks +17 lines, -18 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_unittest.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py View 1 5 chunks +45 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py View 1 5 chunks +62 lines, -37 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores_factory.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores_unittest.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/evaluation.py View 1 1 chunk +15 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/exceptions.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/export.py View 1 8 chunks +96 lines, -39 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation.py View 1 19 chunks +96 lines, -75 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation_factory.py View 1 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/noise_generation_unittest.py View 1 6 chunks +11 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/signal_processing.py View 1 9 chunks +58 lines, -21 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/signal_processing_unittest.py View 1 5 chunks +10 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py View 1 6 chunks +47 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
AleBzk
As agreed in https://codereview.webrtc.org/2718063003/, I finally fixed the style of the APM QA tool.
3 years, 8 months ago (2017-04-05 13:07:07 UTC) #3
kjellander_webrtc
lgtm but consider my comment. https://codereview.webrtc.org/2793903006/diff/20001/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py File webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py (right): https://codereview.webrtc.org/2793903006/diff/20001/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py#newcode33 webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py:33: def InstanceArgumentsParser(): The style ...
3 years, 8 months ago (2017-04-05 14:13:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2793903006/40001
3 years, 8 months ago (2017-04-05 14:23:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/dea682d25b60820af862cfb8f35a761ef1597784
3 years, 8 months ago (2017-04-05 14:25:41 UTC) #10
AleBzk
3 years, 8 months ago (2017-04-05 14:28:51 UTC) #11
Message was sent while issue was closed.
https://codereview.webrtc.org/2793903006/diff/20001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py
(right):

https://codereview.webrtc.org/2793903006/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_export.py:33:
def InstanceArgumentsParser():
On 2017/04/05 14:13:48, kjellander_webrtc wrote:
> The style guide encourages _ for internal names. Why not keep it?
> https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming

Done.

Powered by Google App Engine
This is Rietveld 408576698