Add a minimal RtpTransport class for use by BaseChannel.

Add a minimal RtpTransport class for use by BaseChannel.

This will eventually implement webrtc::RtpTransportInterface from api/ortc.
It needs to live in the pc build target until the pc <- ortc dependency is inverted.

BUG=webrtc:7013
Review-Url: https://codereview.webrtc.org/2792223002
Cr-Commit-Position: refs/heads/master@{#17534}
Committed: https://chromium.googlesource.com/external/webrtc/+/d48dbda43453dc9ff73f07eaf9f1b852b724568f

[Zach Stein, 2017-04-03 23:56:04]

Description was changed from

==========
Add a minimal RtpTransport class for use by BaseChannel.
This will eventually implement webrtc::RtpTransportInterface from api/ortc.
It needs to live in the pc build target until the pc/ortc dependency is
inverted.

BUG=webrtc:7013
==========

to

==========
Add a minimal RtpTransport class for use by BaseChannel.
This will eventually implement webrtc::RtpTransportInterface from api/ortc.
It needs to live in the pc build target until the pc <- ortc dependency is
inverted.

BUG=webrtc:7013
==========

[Zach Stein, 2017-04-04 00:05:45]

zstein@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Zach Stein, 2017-04-04 00:05:46]

Please take a look. I plan on moving more of the muxing logic into RtpTransport
next.

[Zach Stein, 2017-04-04 00:06:14]

The CQ bit was checked by zstein@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 00:06:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-04 00:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 00:47:03]

Dry run: This issue passed the CQ dry run.

[Taylor_Brandstetter, 2017-04-04 16:46:40]

Description was changed from

==========
Add a minimal RtpTransport class for use by BaseChannel.
This will eventually implement webrtc::RtpTransportInterface from api/ortc.
It needs to live in the pc build target until the pc <- ortc dependency is
inverted.

BUG=webrtc:7013
==========

to

==========
Add a minimal RtpTransport class for use by BaseChannel.

This will eventually implement webrtc::RtpTransportInterface from api/ortc.
It needs to live in the pc build target until the pc <- ortc dependency is
inverted.

BUG=webrtc:7013
==========

[Taylor_Brandstetter, 2017-04-04 16:47:31]

deadbeef@chromium.org changed reviewers:
+ deadbeef@chromium.org

[Taylor_Brandstetter, 2017-04-04 16:47:32]

lgtm

https://codereview.webrtc.org/2792223002/diff/20001/webrtc/pc/rtptransport.h
File webrtc/pc/rtptransport.h (right):

https://codereview.webrtc.org/2792223002/diff/20001/webrtc/pc/rtptransport.h#...
webrtc/pc/rtptransport.h:27: explicit RtpTransport(bool rtcp_mux_required)
I think it would make sense for the constructor to also take the initial set of
packet transports. Though this would require some shuffling of code (since the
initial transports are currently set in BaseChannel::SetTransports_n, called
from InitNetwork_n), so we can leave it as a TODO until it becomes more
straightforward.

https://codereview.webrtc.org/2792223002/diff/20001/webrtc/pc/rtptransport.h#...
webrtc/pc/rtptransport.h:50: // owned by TransportController
I'm not so sure about this TODO. The current ownership model with the ORTC API
is that the application owns all created objects. We can talk about this more
later.

[Zach Stein, 2017-04-04 21:31:12]

The CQ bit was checked by zstein@webrtc.org

[Zach Stein, 2017-04-04 21:31:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
deadbeef@chromium.org
Link to the patchset: https://codereview.webrtc.org/2792223002/#ps40001 (title:
"updating a TODO")

[commit-bot: I haz the power, 2017-04-04 21:31:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-04 21:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 21:31:19]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[Taylor Brandstetter, 2017-04-05 00:46:40]

lgtm (sorry bout that)

[Zach Stein, 2017-04-05 02:24:20]

The CQ bit was checked by zstein@webrtc.org

[commit-bot: I haz the power, 2017-04-05 02:24:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-05 02:45:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491359060432040,
"parent_rev": "465faf0061131100774503f9110abbc130092dcf", "commit_rev":
"d48dbda43453dc9ff73f07eaf9f1b852b724568f"}

[commit-bot: I haz the power, 2017-04-05 02:46:02]

Description was changed from

==========
Add a minimal RtpTransport class for use by BaseChannel.

This will eventually implement webrtc::RtpTransportInterface from api/ortc.
It needs to live in the pc build target until the pc <- ortc dependency is
inverted.

BUG=webrtc:7013
==========

to

==========
Add a minimal RtpTransport class for use by BaseChannel.

This will eventually implement webrtc::RtpTransportInterface from api/ortc.
It needs to live in the pc build target until the pc <- ortc dependency is
inverted.

BUG=webrtc:7013

Review-Url: https://codereview.webrtc.org/2792223002
Cr-Commit-Position: refs/heads/master@{#17534}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d48dbda43453dc9ff73f07eaf...
==========

[commit-bot: I haz the power, 2017-04-05 02:46:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/d48dbda43453dc9ff73f07eaf...