Revert of Deliver video frames on Android, on the decode thread.

Revert of Deliver video frames on Android, on the decode thread. (patchset #7 id:120001 of https://codereview.webrtc.org/2764573002/ )

Reason for revert:
Breaks Chrome FYI Android bots.

See:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28L%20Nexus9%29/builds/20418
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28L%20Nexus6%29/builds/14724
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28L%20Nexus5%29/builds/20133
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28K%20Nexus5%29/builds/15111

Original issue's description:
> Deliver video frames on Android, on the decode thread.
> 
> VideoCoding
> * Adding a method for polling for frames on Android only until the capture implementation takes care of this (longer term plan).
> 
> CodecDatabase
> * Add an accessor for the current decoder
> * Use std::unique_ptr<> for ownership.
> * Remove "Release()" and "ReleaseDecoder()". Instead just delete.
> * Remove |friend| relationship between CodecDatabase and VCMGenericDecoder.
> 
> VCMDecodedFrameCallback
> * DCHECKs for thread correctness.
> * Remove |lock_| now that a threading model has been established and verified.
> 
> VCMGenericDecoder
> * All methods now have thread checks.
> * Variable access associated with thread checkers.
> 
> VideoReceiver
> * Added two notification methods, DecoderThreadStarting() and DecoderThreadStopped()
>   * Allows us to establish a period when the decoder thread is not running and it is safe to modify variables such as callbacks, that are only read when the decoder thread is running.
>   * Allows us to DCHECK thread guarantees.
>   * Allows synchronizing callbacks from the module process thread and have them only active while the decoder thread is running.
>   * The above, allows us to establish two modes for the thread, single-threaded-mutable and multi-threaded-const.
>   * Using that knowledge, we can remove |receive_crit_| as well as locking for a number of member variables.
> 
> MediaCodecVideoDecoder
> * Removed frame polling code from this class, since this is now done from the root thread function in VideoReceiveStream.
> 
> VideoReceiveStream
> * On Android: Polls for decoded frames every 10ms (same interval as previously in MediaCodecVideoDecoder)
> * [Un]Registers the |video_receiver_| with the module thread only around the time the decoder thread is started/stopped.
> * Notifies the receiver of start/stop events of the decoder thread.
> * Changed the decoder thread to use the new PlatformThread callback type.
> 
> BUG=webrtc:7361, 695438
> 
> Review-Url: https://codereview.webrtc.org/2764573002
> Cr-Commit-Position: refs/heads/master@{#17527}
> Committed: https://chromium.googlesource.com/external/webrtc/+/e3aa88bbd5accadec73fa7e38584dfbf6aabe8a9

TBR=sakal@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7361, 695438
Review-Url: https://codereview.webrtc.org/2792033003
Cr-Commit-Position: refs/heads/master@{#17530}
Committed: https://chromium.googlesource.com/external/webrtc/+/c3372583d4314eff1c6ab4a965b746aca08a06f8

[guidou, 2017-04-04 14:16:02]

The CQ bit was checked by guidou@webrtc.org

[guidou, 2017-04-04 14:16:02]

Created Revert of Deliver video frames on Android, on the decode thread.

[commit-bot: I haz the power, 2017-04-04 14:16:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-04 14:16:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491315362022220, "parent_rev":
"fbd4f85f2dab93d819e42d1b1dfc6e2b2125ddf2", "commit_rev":
"c3372583d4314eff1c6ab4a965b746aca08a06f8"}

[commit-bot: I haz the power, 2017-04-04 14:16:24]

Description was changed from

==========
Revert of Deliver video frames on Android, on the decode thread. (patchset #7
id:120001 of https://codereview.webrtc.org/2764573002/ )

Reason for revert:
Breaks Chrome FYI Android bots.

See:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...

Original issue's description:
> Deliver video frames on Android, on the decode thread.
> 
> VideoCoding
> * Adding a method for polling for frames on Android only until the capture
implementation takes care of this (longer term plan).
> 
> CodecDatabase
> * Add an accessor for the current decoder
> * Use std::unique_ptr<> for ownership.
> * Remove "Release()" and "ReleaseDecoder()". Instead just delete.
> * Remove |friend| relationship between CodecDatabase and VCMGenericDecoder.
> 
> VCMDecodedFrameCallback
> * DCHECKs for thread correctness.
> * Remove |lock_| now that a threading model has been established and verified.
> 
> VCMGenericDecoder
> * All methods now have thread checks.
> * Variable access associated with thread checkers.
> 
> VideoReceiver
> * Added two notification methods, DecoderThreadStarting() and
DecoderThreadStopped()
>   * Allows us to establish a period when the decoder thread is not running and
it is safe to modify variables such as callbacks, that are only read when the
decoder thread is running.
>   * Allows us to DCHECK thread guarantees.
>   * Allows synchronizing callbacks from the module process thread and have
them only active while the decoder thread is running.
>   * The above, allows us to establish two modes for the thread,
single-threaded-mutable and multi-threaded-const.
>   * Using that knowledge, we can remove |receive_crit_| as well as locking for
a number of member variables.
> 
> MediaCodecVideoDecoder
> * Removed frame polling code from this class, since this is now done from the
root thread function in VideoReceiveStream.
> 
> VideoReceiveStream
> * On Android: Polls for decoded frames every 10ms (same interval as previously
in MediaCodecVideoDecoder)
> * [Un]Registers the |video_receiver_| with the module thread only around the
time the decoder thread is started/stopped.
> * Notifies the receiver of start/stop events of the decoder thread.
> * Changed the decoder thread to use the new PlatformThread callback type.
> 
> BUG=webrtc:7361, 695438
> 
> Review-Url: https://codereview.webrtc.org/2764573002
> Cr-Commit-Position: refs/heads/master@{#17527}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/e3aa88bbd5accadec73fa7e38...

TBR=sakal@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7361, 695438
==========

to

==========
Revert of Deliver video frames on Android, on the decode thread. (patchset #7
id:120001 of https://codereview.webrtc.org/2764573002/ )

Reason for revert:
Breaks Chrome FYI Android bots.

See:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%...

Original issue's description:
> Deliver video frames on Android, on the decode thread.
> 
> VideoCoding
> * Adding a method for polling for frames on Android only until the capture
implementation takes care of this (longer term plan).
> 
> CodecDatabase
> * Add an accessor for the current decoder
> * Use std::unique_ptr<> for ownership.
> * Remove "Release()" and "ReleaseDecoder()". Instead just delete.
> * Remove |friend| relationship between CodecDatabase and VCMGenericDecoder.
> 
> VCMDecodedFrameCallback
> * DCHECKs for thread correctness.
> * Remove |lock_| now that a threading model has been established and verified.
> 
> VCMGenericDecoder
> * All methods now have thread checks.
> * Variable access associated with thread checkers.
> 
> VideoReceiver
> * Added two notification methods, DecoderThreadStarting() and
DecoderThreadStopped()
>   * Allows us to establish a period when the decoder thread is not running and
it is safe to modify variables such as callbacks, that are only read when the
decoder thread is running.
>   * Allows us to DCHECK thread guarantees.
>   * Allows synchronizing callbacks from the module process thread and have
them only active while the decoder thread is running.
>   * The above, allows us to establish two modes for the thread,
single-threaded-mutable and multi-threaded-const.
>   * Using that knowledge, we can remove |receive_crit_| as well as locking for
a number of member variables.
> 
> MediaCodecVideoDecoder
> * Removed frame polling code from this class, since this is now done from the
root thread function in VideoReceiveStream.
> 
> VideoReceiveStream
> * On Android: Polls for decoded frames every 10ms (same interval as previously
in MediaCodecVideoDecoder)
> * [Un]Registers the |video_receiver_| with the module thread only around the
time the decoder thread is started/stopped.
> * Notifies the receiver of start/stop events of the decoder thread.
> * Changed the decoder thread to use the new PlatformThread callback type.
> 
> BUG=webrtc:7361, 695438
> 
> Review-Url: https://codereview.webrtc.org/2764573002
> Cr-Commit-Position: refs/heads/master@{#17527}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/e3aa88bbd5accadec73fa7e38...

TBR=sakal@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7361, 695438

Review-Url: https://codereview.webrtc.org/2792033003
Cr-Commit-Position: refs/heads/master@{#17530}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c3372583d4314eff1c6ab4a96...
==========

[commit-bot: I haz the power, 2017-04-04 14:16:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c3372583d4314eff1c6ab4a96...

[tommi, 2017-04-11 12:52:07]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2811963004/ by tommi@webrtc.org.

The reason for reverting is: Preparing to reland. Will include Sami's changes..