Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Issue 2791453004: Revert of Supporting 48kHz PCM file. (Closed)

Created:
3 years, 8 months ago by lliuu
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, peah-webrtc, minyue-webrtc, the sun, AleBzk
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Supporting 48kHz PCM file. (patchset #1 id:1 of https://codereview.webrtc.org/2790493004/ ) Reason for revert: broke internal project Original issue's description: > Supporting 48kHz PCM file. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2790493004 > Cr-Commit-Position: refs/heads/master@{#17493} > Committed: https://chromium.googlesource.com/external/webrtc/+/5f93709e7c65faa9616f09368a92d47087b778f5 TBR=niklas.enbom@webrtc.org,solenberg@webrtc.org,minyue@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2791453004 Cr-Commit-Position: refs/heads/master@{#17496} Committed: https://chromium.googlesource.com/external/webrtc/+/bc436ede076cff1b1c12045c3bf0bb9b9a1c0e24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -59 lines) Patch
M webrtc/common_types.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/media_file/media_file_impl.cc View 6 chunks +4 lines, -10 lines 0 comments Download
M webrtc/modules/media_file/media_file_utility.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_utility.cc View 3 chunks +4 lines, -30 lines 0 comments Download
M webrtc/voice_engine/file_player.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/file_player.cc View 5 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lliuu
Created Revert of Supporting 48kHz PCM file.
3 years, 8 months ago (2017-03-31 23:32:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2791453004/1
3 years, 8 months ago (2017-03-31 23:32:24 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 23:32:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bc436ede076cff1b1c12045c3...

Powered by Google App Engine
This is Rietveld 408576698