Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2790883002: remove module-wide warning suppression. (Closed)

Created:
3 years, 8 months ago by kthelgason
Modified:
3 years, 8 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

remove module-wide warning suppression. The warnings in question are benign and should be supressed locally so we can keep the analysis for the rest of the files. BUG=webrtc:5748 Review-Url: https://codereview.webrtc.org/2790883002 Cr-Commit-Position: refs/heads/master@{#17485} Committed: https://chromium.googlesource.com/external/webrtc/+/ee8b8611904ec0eaf600acba8561750a9e45cb85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kthelgason
3 years, 8 months ago (2017-03-31 09:47:14 UTC) #4
henrika_webrtc
LGTM % the fact that I don't know the details well enough to spot any ...
3 years, 8 months ago (2017-03-31 10:15:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2790883002/1
3 years, 8 months ago (2017-03-31 11:48:16 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 11:50:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ee8b8611904ec0eaf600acba8...

Powered by Google App Engine
This is Rietveld 408576698