Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2790533002: Remove ALL usage of CriticalSectionWrapper. (Closed)

Created:
3 years, 8 months ago by kthelgason
Modified:
3 years, 8 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, fengyue_agora.io, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, perkj_webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ALL usage of CriticalSectionWrapper. Finally we are able to remove this class entirely, along with the last vestiges of it's use. I've also removed some legacy files that were only used for windows XP support. BUG=webrtc:7035 Review-Url: https://codereview.webrtc.org/2790533002 Cr-Commit-Position: refs/heads/master@{#17480} Committed: https://chromium.googlesource.com/external/webrtc/+/ff046c74c50c98bcd79274c31c10a65327c31ef1

Patch Set 1 #

Patch Set 2 : Forgot some windows files #

Patch Set 3 : remove winXP rw_lock include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -949 lines) Patch
M webrtc/modules/audio_conference_mixer/source/memory_pool_posix.h View 6 chunks +7 lines, -9 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/time_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.cc View 16 chunks +14 lines, -16 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_mixer_manager_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_mixer_manager_mac.cc View 13 chunks +11 lines, -16 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 8 chunks +7 lines, -9 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.cc View 11 chunks +14 lines, -16 lines 0 comments Download
M webrtc/modules/video_capture/linux/video_capture_linux.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/linux/video_capture_linux.cc View 9 chunks +3 lines, -14 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 5 chunks +4 lines, -8 lines 0 comments Download
M webrtc/modules/video_capture/windows/video_capture_ds.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/packet_manipulator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/packet_manipulator.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.h View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.cc View 23 chunks +29 lines, -32 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 4 chunks +0 lines, -7 lines 0 comments Download
D webrtc/system_wrappers/include/critical_section_wrapper.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable_event_win.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable_event_win.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D webrtc/system_wrappers/source/condition_variable_unittest.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D webrtc/system_wrappers/source/critical_section_unittest.cc View 1 chunk +0 lines, -135 lines 0 comments Download
M webrtc/system_wrappers/source/rw_lock.cc View 1 2 2 chunks +1 line, -7 lines 0 comments Download
D webrtc/system_wrappers/source/rw_lock_winxp_win.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/system_wrappers/source/rw_lock_winxp_win.cc View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
kthelgason
Last one in the exciting series.
3 years, 8 months ago (2017-03-30 10:59:59 UTC) #14
tommi
lgtm
3 years, 8 months ago (2017-03-31 08:34:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2790533002/40001
3 years, 8 months ago (2017-03-31 09:00:48 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 09:04:00 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/ff046c74c50c98bcd79274c31...

Powered by Google App Engine
This is Rietveld 408576698