Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: webrtc/video_receive_stream.h

Issue 2789843002: Delete VieRemb class, move functionality to PacketRouter. (Closed)
Patch Set: Delete obsolete suppression for PacketRouterTest.SendTransportFeedback. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/vie_remb_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video_receive_stream.h
diff --git a/webrtc/video_receive_stream.h b/webrtc/video_receive_stream.h
index 33d779d9b39444ab09a53d8457e879034dcf41f2..b3a98c617ac2ebc120bf50f557faf537af47ba52 100644
--- a/webrtc/video_receive_stream.h
+++ b/webrtc/video_receive_stream.h
@@ -132,6 +132,15 @@ class VideoReceiveStream {
bool receiver_reference_time_report = false;
} rtcp_xr;
+ // TODO(nisse): This remb setting is currently set but never
+ // applied. REMB logic is now the responsibility of
+ // PacketRouter, and it will generate REMB feedback if
+ // OnReceiveBitrateChanged is used, which depends on how the
+ // estimators belonging to the ReceiveSideCongestionController
+ // are configured. Decide if this setting should be deleted, and
+ // if it needs to be replaced by a setting in PacketRouter to
+ // disable REMB feedback.
+
// See draft-alvestrand-rmcat-remb for information.
bool remb = false;
« no previous file with comments | « webrtc/video/vie_remb_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698